From 068f59f47bf8d5c66ca8a4e8970d9ca420dcba79 Mon Sep 17 00:00:00 2001 From: Josh Humphries Date: Thu, 15 Nov 2018 20:13:17 -0500 Subject: [PATCH] add comment/todo --- grpcurl.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/grpcurl.go b/grpcurl.go index c72d6cd..990761d 100644 --- a/grpcurl.go +++ b/grpcurl.go @@ -516,6 +516,8 @@ func ClientTransportCredentials(insecureSkipVerify bool, cacertFile, clientCertF // client certs. The serverCertFile and serverKeyFile must both not be blank. func ServerTransportCredentials(cacertFile, serverCertFile, serverKeyFile string, requireClientCerts bool) (credentials.TransportCredentials, error) { var tlsConf tls.Config + // TODO(jh): Remove this line once https://github.com/golang/go/issues/28779 is fixed + // in Go tip. Until then, the recently merged TLS 1.3 support breaks the TLS tests. tlsConf.MaxVersion = tls.VersionTLS12 // Load the server certificates from disk