add test for WriteProtoset

This commit is contained in:
Josh Humphries 2019-09-29 21:13:02 -04:00
parent 252d61c7a9
commit 4ebb88c4cb
3 changed files with 64 additions and 2 deletions

View File

@ -647,4 +647,4 @@ func writeProtoset(descSource grpcurl.DescriptorSource, symbols ...string) error
} }
defer f.Close() defer f.Close()
return grpcurl.WriteProtoset(f, descSource, symbols...) return grpcurl.WriteProtoset(f, descSource, symbols...)
} }

View File

@ -301,4 +301,4 @@ func addFilesToSet(seen map[string]struct{}, fds *[]*descpb.FileDescriptorProto,
addFilesToSet(seen, fds, dep) addFilesToSet(seen, fds, dep)
} }
*fds = append(*fds, fd.AsFileDescriptorProto()) *fds = append(*fds, fd.AsFileDescriptorProto())
} }

62
desc_source_test.go Normal file
View File

@ -0,0 +1,62 @@
package grpcurl
import (
"bytes"
"io/ioutil"
"testing"
"github.com/golang/protobuf/proto"
"github.com/golang/protobuf/protoc-gen-go/descriptor"
)
func TestWriteProtoset(t *testing.T) {
exampleProtoset, err := loadProtoset("./testing/example.protoset")
if err != nil {
t.Fatalf("failed to load example.protoset: %v", err)
}
testProtoset, err := loadProtoset("./testing/test.protoset")
if err != nil {
t.Fatalf("failed to load test.protoset: %v", err)
}
mergedProtoset := &descriptor.FileDescriptorSet{
File: append(exampleProtoset.File, testProtoset.File...),
}
descSrc, err := DescriptorSourceFromFileDescriptorSet(mergedProtoset)
if err != nil {
t.Fatalf("failed to create descriptor source: %v", err)
}
checkWriteProtoset(t, descSrc, exampleProtoset, "TestService")
checkWriteProtoset(t, descSrc, testProtoset, "grpc.testing.TestService")
checkWriteProtoset(t, descSrc, mergedProtoset, "TestService", "grpc.testing.TestService")
}
func loadProtoset(path string) (*descriptor.FileDescriptorSet, error) {
b, err := ioutil.ReadFile(path)
if err != nil {
return nil, err
}
var protoset descriptor.FileDescriptorSet
if err := proto.Unmarshal(b, &protoset); err != nil {
return nil, err
}
return &protoset, nil
}
func checkWriteProtoset(t *testing.T, descSrc DescriptorSource, protoset *descriptor.FileDescriptorSet, symbols ...string) {
var buf bytes.Buffer
if err := WriteProtoset(&buf, descSrc, symbols...); err != nil {
t.Fatalf("failed to write protoset: %v", err)
}
var result descriptor.FileDescriptorSet
if err := proto.Unmarshal(buf.Bytes(), &result); err != nil {
t.Fatalf("failed to unmarshal written protoset: %v", err)
}
if !proto.Equal(protoset, &result) {
t.Fatalf("written protoset not equal to input:\nExpecting: %s\nActual: %s", protoset, &result)
}
}