diff --git a/.gitignore b/.gitignore index 70d5bc1..c02e0f5 100644 --- a/.gitignore +++ b/.gitignore @@ -1,4 +1,5 @@ dist/ +.claude/ .idea/ VERSION .tmp/ diff --git a/cmd/grpcurl/grpcurl.go b/cmd/grpcurl/grpcurl.go index d8b1bf3..da58705 100644 --- a/cmd/grpcurl/grpcurl.go +++ b/cmd/grpcurl/grpcurl.go @@ -15,7 +15,7 @@ import ( "strings" "time" - "github.com/jhump/protoreflect/desc" //lint:ignore SA1019 required to use APIs in other grpcurl package + "github.com/jhump/protoreflect/desc" "github.com/jhump/protoreflect/grpcreflect" "google.golang.org/grpc" "google.golang.org/grpc/codes" diff --git a/desc_source.go b/desc_source.go index b879cf2..21dcd7a 100644 --- a/desc_source.go +++ b/desc_source.go @@ -9,11 +9,11 @@ import ( "path/filepath" "sync" - "github.com/golang/protobuf/proto" //lint:ignore SA1019 we have to import these because some of their types appear in exported API - "github.com/jhump/protoreflect/desc" //lint:ignore SA1019 same as above - "github.com/jhump/protoreflect/desc/protoparse" //lint:ignore SA1019 same as above + "github.com/golang/protobuf/proto" + "github.com/jhump/protoreflect/desc" + "github.com/jhump/protoreflect/desc/protoparse" "github.com/jhump/protoreflect/desc/protoprint" - "github.com/jhump/protoreflect/dynamic" //lint:ignore SA1019 same as above + "github.com/jhump/protoreflect/dynamic" "github.com/jhump/protoreflect/grpcreflect" "google.golang.org/grpc/codes" "google.golang.org/grpc/status" diff --git a/format.go b/format.go index e7f576b..5d802be 100644 --- a/format.go +++ b/format.go @@ -11,10 +11,10 @@ import ( "strings" "sync" - "github.com/golang/protobuf/jsonpb" //lint:ignore SA1019 we have to import these because some of their types appear in exported API - "github.com/golang/protobuf/proto" //lint:ignore SA1019 same as above - "github.com/jhump/protoreflect/desc" //lint:ignore SA1019 same as above - "github.com/jhump/protoreflect/dynamic" //lint:ignore SA1019 same as above + "github.com/golang/protobuf/jsonpb" + "github.com/golang/protobuf/proto" + "github.com/jhump/protoreflect/desc" + "github.com/jhump/protoreflect/dynamic" "google.golang.org/grpc/codes" "google.golang.org/grpc/metadata" "google.golang.org/grpc/status" @@ -330,7 +330,6 @@ func (r anyResolverWithFallback) Resolve(typeUrl string) (proto.Message, error) if slash := strings.LastIndex(mname, "/"); slash >= 0 { mname = mname[slash+1:] } - //lint:ignore SA1019 new non-deprecated API requires other code changes; deferring... mt := proto.MessageType(mname) if mt != nil { return reflect.New(mt.Elem()).Interface().(proto.Message), nil diff --git a/format_test.go b/format_test.go index e4d51b1..96f64ef 100644 --- a/format_test.go +++ b/format_test.go @@ -7,9 +7,9 @@ import ( "strings" "testing" - "github.com/golang/protobuf/jsonpb" //lint:ignore SA1019 we have to import these because some of their types appear in exported API - "github.com/golang/protobuf/proto" //lint:ignore SA1019 same as above - "github.com/jhump/protoreflect/desc" //lint:ignore SA1019 same as above + "github.com/golang/protobuf/jsonpb" + "github.com/golang/protobuf/proto" + "github.com/jhump/protoreflect/desc" "google.golang.org/grpc/metadata" "google.golang.org/protobuf/types/known/structpb" ) diff --git a/grpcurl.go b/grpcurl.go index c970d3d..15f1e8c 100644 --- a/grpcurl.go +++ b/grpcurl.go @@ -23,10 +23,10 @@ import ( "sync" "time" - "github.com/golang/protobuf/proto" //lint:ignore SA1019 we have to import these because some of their types appear in exported API - "github.com/jhump/protoreflect/desc" //lint:ignore SA1019 same as above + "github.com/golang/protobuf/proto" + "github.com/jhump/protoreflect/desc" "github.com/jhump/protoreflect/desc/protoprint" - "github.com/jhump/protoreflect/dynamic" //lint:ignore SA1019 same as above + "github.com/jhump/protoreflect/dynamic" "google.golang.org/grpc" "google.golang.org/grpc/connectivity" "google.golang.org/grpc/credentials" diff --git a/grpcurl_test.go b/grpcurl_test.go index d4ef43f..e4afba6 100644 --- a/grpcurl_test.go +++ b/grpcurl_test.go @@ -12,9 +12,9 @@ import ( "testing" "time" - "github.com/golang/protobuf/jsonpb" //lint:ignore SA1019 we have to import these because some of their types appear in exported API - "github.com/golang/protobuf/proto" //lint:ignore SA1019 same as above - "github.com/jhump/protoreflect/desc" //lint:ignore SA1019 same as above + "github.com/golang/protobuf/jsonpb" + "github.com/golang/protobuf/proto" + "github.com/jhump/protoreflect/desc" "github.com/jhump/protoreflect/grpcreflect" "google.golang.org/grpc" "google.golang.org/grpc/codes" diff --git a/invoke.go b/invoke.go index 860dae5..30bdeed 100644 --- a/invoke.go +++ b/invoke.go @@ -9,10 +9,10 @@ import ( "sync" "sync/atomic" - "github.com/golang/protobuf/jsonpb" //lint:ignore SA1019 we have to import these because some of their types appear in exported API - "github.com/golang/protobuf/proto" //lint:ignore SA1019 same as above - "github.com/jhump/protoreflect/desc" //lint:ignore SA1019 same as above - "github.com/jhump/protoreflect/dynamic" //lint:ignore SA1019 same as above + "github.com/golang/protobuf/jsonpb" + "github.com/golang/protobuf/proto" + "github.com/jhump/protoreflect/desc" + "github.com/jhump/protoreflect/dynamic" "github.com/jhump/protoreflect/dynamic/grpcdynamic" "github.com/jhump/protoreflect/grpcreflect" "google.golang.org/grpc"