astelm
/
grpcurl
mirror of https://github.com/fullstorydev/grpcurl.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: Update TLS error checks for Go 1.25 compatibility (#522) 

The error message for client certificate failures changed in Go 1.25.
Update tests to check for both the old ("bad certificate") and new
("handshake failure") error strings to support multiple Go versions.

Signed-off-by: Mikel Olasagasti Uranga <mikel@olasagasti.info>
This commit is contained in:
Mikel Olasagasti Uranga 2025-07-25 00:11:12 +02:00 committed by GitHub
parent 7155fb6211
commit 7ad93a42d9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
tls_settings_test.go
View File

@ -253,8 +253,12 @@ func TestBrokenTLS_ClientNotTrusted(t *testing.T) {
e.Close() e.Close()
t.Fatal("expecting TLS failure setting up server and client") t.Fatal("expecting TLS failure setting up server and client")
} }
if !strings.Contains(err.Error(), "bad certificate") { // Check for either the old error (Go <=1.24) or the new one (Go 1.25+)
t.Fatalf("expecting TLS certificate error, got: %v", err) // Go 1.24: "bad certificate"
// Go 1.25: "handshake failure"
errMsg := err.Error()
if !strings.Contains(errMsg, "bad certificate") && !strings.Contains(errMsg, "handshake failure") {
t.Fatalf("expecting a specific TLS certificate or handshake error, got: %v", err)
} }
} }
@ -293,8 +297,12 @@ func TestBrokenTLS_RequireClientCertButNonePresented(t *testing.T) {
e.Close() e.Close()
t.Fatal("expecting TLS failure setting up server and client") t.Fatal("expecting TLS failure setting up server and client")
} }
if !strings.Contains(err.Error(), "bad certificate") { // Check for either the old error (Go <=1.24) or the new one (Go 1.25+)
t.Fatalf("expecting TLS certificate error, got: %v", err) // Go 1.24: "bad certificate"
// Go 1.25: "handshake failure"
errMsg := err.Error()
if !strings.Contains(errMsg, "bad certificate") && !strings.Contains(errMsg, "handshake failure") {
t.Fatalf("expecting a specific TLS certificate or handshake error, got: %v", err)
} }
} }