From 9a04e95750c5b7a8979b26d5e3d86bdb93b03d8d Mon Sep 17 00:00:00 2001 From: Josh Humphries Date: Sun, 16 Dec 2018 22:48:55 -0500 Subject: [PATCH] ignore deprecated check for now --- Makefile | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 0c8af40..722eff6 100644 --- a/Makefile +++ b/Makefile @@ -36,10 +36,18 @@ checkgofmt: vet: go vet ./... +# TODO: remove the ignored check; need it for now because it +# is complaining about a deprecated comment added to grpc, +# but it's not yet released. Once the new (non-deprecated) +# API is included in a release, we can move to that new +# version and fix the call site to no longer use deprecated +# method. +# This all works fine with Go modules, but without modules, +# CI is just getting latest master for dependencies like grpc. .PHONY: staticcheck staticcheck: @go get honnef.co/go/tools/cmd/staticcheck - staticcheck ./... + staticcheck -ignore github.com/fullstorydev/grpcurl/tls_settings_test.go:SA1019 ./... .PHONY: unused unused: