make method invocation resilient to errors trying to load all files from server (#74)

format.go

@@ -189,10 +189,14 @@ const (
 )
 
 func anyResolver(source DescriptorSource) (jsonpb.AnyResolver, error) {
-	files, err := GetAllFiles(source)
+	// TODO: instead of pro-actively downloading file descriptors to
-	if err != nil {
+	// build a dynamic resolver, it would be better if the resolver
-		return nil, err
+	// impl was lazy, and simply downloaded the descriptors as needed
-	}
+	// when asked to resolve a particular type URL
+
+	// best effort: build resolver with whatever files we can
+	// load, ignoring any errors
+	files, _ := GetAllFiles(source)
 
 	var er dynamic.ExtensionRegistry
 	for _, fd := range files {

format_test.go

@@ -14,7 +14,7 @@ import (
 	"google.golang.org/grpc/metadata"
 )
 
-func TestRequestFactory(t *testing.T) {
+func TestRequestParser(t *testing.T) {
 	source, err := DescriptorSourceFromProtoSets("testing/example.protoset")
 	if err != nil {
 		t.Fatalf("failed to create descriptor source: %v", err)

grpcurl.go

@@ -55,27 +55,29 @@ func GetAllFiles(source DescriptorSource) ([]*desc.FileDescriptor, error) {
 	var files []*desc.FileDescriptor
 	srcFiles, ok := source.(sourceWithFiles)
 
+	// If an error occurs, we still try to load as many files as we can, so that
+	// caller can decide whether to ignore error or not.
+	var firstError error
 	if ok {
-		var err error
+		files, firstError = srcFiles.GetAllFiles()
-		files, err = srcFiles.GetAllFiles()
-		if err != nil {
-			return nil, err
-		}
 	} else {
 		// Source does not implement GetAllFiles method, so use ListServices
 		// and grab files from there.
-		allFiles := map[string]*desc.FileDescriptor{}
 		svcNames, err := source.ListServices()
 		if err != nil {
-			return nil, err
+			firstError = err
-		}
+		} else {
+			allFiles := map[string]*desc.FileDescriptor{}
 			for _, name := range svcNames {
 				d, err := source.FindSymbol(name)
 				if err != nil {
-				return nil, err
+					if firstError == nil {
+						firstError = err
 					}
+				} else {
 					addAllFilesToSet(d.GetFile(), allFiles)
 				}
+			}
 			files = make([]*desc.FileDescriptor, len(allFiles))
 			i := 0
 			for _, fd := range allFiles {
@@ -83,9 +85,10 @@ func GetAllFiles(source DescriptorSource) ([]*desc.FileDescriptor, error) {
 				i++
 			}
 		}
+	}
 
 	sort.Sort(filesByName(files))
-	return files, nil
+	return files, firstError
 }
 
 type filesByName []*desc.FileDescriptor