From bf98d79f8be68a7a5fdee0f26654c6dd7f6c70f1 Mon Sep 17 00:00:00 2001 From: Josh Humphries <2035234+jhump@users.noreply.github.com> Date: Fri, 10 Jan 2025 12:49:02 -0500 Subject: [PATCH] add lint:ignore annotations to fix CI --- cmd/grpcurl/grpcurl.go | 2 +- desc_source.go | 8 ++++---- format.go | 8 ++++---- format_test.go | 6 +++--- grpcurl.go | 6 +++--- grpcurl_test.go | 6 +++--- invoke.go | 8 ++++---- 7 files changed, 22 insertions(+), 22 deletions(-) diff --git a/cmd/grpcurl/grpcurl.go b/cmd/grpcurl/grpcurl.go index 80f87bf..5604ac4 100644 --- a/cmd/grpcurl/grpcurl.go +++ b/cmd/grpcurl/grpcurl.go @@ -14,7 +14,7 @@ import ( "strings" "time" - "github.com/jhump/protoreflect/desc" + "github.com/jhump/protoreflect/desc" //lint:ignore SA1019 required to use APIs in other grpcurl package "github.com/jhump/protoreflect/grpcreflect" "google.golang.org/grpc" "google.golang.org/grpc/codes" diff --git a/desc_source.go b/desc_source.go index 87f1403..258c346 100644 --- a/desc_source.go +++ b/desc_source.go @@ -9,11 +9,11 @@ import ( "path/filepath" "sync" - "github.com/golang/protobuf/proto" //lint:ignore SA1019 we have to import this because it appears in exported API - "github.com/jhump/protoreflect/desc" - "github.com/jhump/protoreflect/desc/protoparse" + "github.com/golang/protobuf/proto" //lint:ignore SA1019 we have to import these because some of their types appear in exported API + "github.com/jhump/protoreflect/desc" //lint:ignore SA1019 same as above + "github.com/jhump/protoreflect/desc/protoparse" //lint:ignore SA1019 same as above "github.com/jhump/protoreflect/desc/protoprint" - "github.com/jhump/protoreflect/dynamic" + "github.com/jhump/protoreflect/dynamic" //lint:ignore SA1019 same as above "github.com/jhump/protoreflect/grpcreflect" "google.golang.org/grpc/codes" "google.golang.org/grpc/status" diff --git a/format.go b/format.go index 8672ef0..e7f576b 100644 --- a/format.go +++ b/format.go @@ -11,10 +11,10 @@ import ( "strings" "sync" - "github.com/golang/protobuf/jsonpb" //lint:ignore SA1019 we have to import this because it appears in exported API - "github.com/golang/protobuf/proto" //lint:ignore SA1019 we have to import this because it appears in exported API - "github.com/jhump/protoreflect/desc" - "github.com/jhump/protoreflect/dynamic" + "github.com/golang/protobuf/jsonpb" //lint:ignore SA1019 we have to import these because some of their types appear in exported API + "github.com/golang/protobuf/proto" //lint:ignore SA1019 same as above + "github.com/jhump/protoreflect/desc" //lint:ignore SA1019 same as above + "github.com/jhump/protoreflect/dynamic" //lint:ignore SA1019 same as above "google.golang.org/grpc/codes" "google.golang.org/grpc/metadata" "google.golang.org/grpc/status" diff --git a/format_test.go b/format_test.go index dd7454e..e4d51b1 100644 --- a/format_test.go +++ b/format_test.go @@ -7,9 +7,9 @@ import ( "strings" "testing" - "github.com/golang/protobuf/jsonpb" //lint:ignore SA1019 we have to import this because it appears in exported API - "github.com/golang/protobuf/proto" //lint:ignore SA1019 we have to import this because it appears in exported API - "github.com/jhump/protoreflect/desc" + "github.com/golang/protobuf/jsonpb" //lint:ignore SA1019 we have to import these because some of their types appear in exported API + "github.com/golang/protobuf/proto" //lint:ignore SA1019 same as above + "github.com/jhump/protoreflect/desc" //lint:ignore SA1019 same as above "google.golang.org/grpc/metadata" "google.golang.org/protobuf/types/known/structpb" ) diff --git a/grpcurl.go b/grpcurl.go index 9c8b08b..4407d8a 100644 --- a/grpcurl.go +++ b/grpcurl.go @@ -20,10 +20,10 @@ import ( "sort" "strings" - "github.com/golang/protobuf/proto" //lint:ignore SA1019 we have to import this because it appears in exported API - "github.com/jhump/protoreflect/desc" + "github.com/golang/protobuf/proto" //lint:ignore SA1019 we have to import these because some of their types appear in exported API + "github.com/jhump/protoreflect/desc" //lint:ignore SA1019 same as above "github.com/jhump/protoreflect/desc/protoprint" - "github.com/jhump/protoreflect/dynamic" + "github.com/jhump/protoreflect/dynamic" //lint:ignore SA1019 same as above "google.golang.org/grpc" "google.golang.org/grpc/credentials" "google.golang.org/grpc/credentials/insecure" diff --git a/grpcurl_test.go b/grpcurl_test.go index 018a6eb..f23bc0f 100644 --- a/grpcurl_test.go +++ b/grpcurl_test.go @@ -12,9 +12,9 @@ import ( "testing" "time" - "github.com/golang/protobuf/jsonpb" //lint:ignore SA1019 we have to import this because it appears in exported API - "github.com/golang/protobuf/proto" //lint:ignore SA1019 we have to import this because it appears in exported API - "github.com/jhump/protoreflect/desc" + "github.com/golang/protobuf/jsonpb" //lint:ignore SA1019 we have to import these because some of their types appear in exported API + "github.com/golang/protobuf/proto" //lint:ignore SA1019 same as above + "github.com/jhump/protoreflect/desc" //lint:ignore SA1019 same as above "github.com/jhump/protoreflect/grpcreflect" "google.golang.org/grpc" "google.golang.org/grpc/codes" diff --git a/invoke.go b/invoke.go index 193c285..860dae5 100644 --- a/invoke.go +++ b/invoke.go @@ -9,10 +9,10 @@ import ( "sync" "sync/atomic" - "github.com/golang/protobuf/jsonpb" //lint:ignore SA1019 we have to import this because it appears in exported API - "github.com/golang/protobuf/proto" //lint:ignore SA1019 we have to import this because it appears in exported API - "github.com/jhump/protoreflect/desc" - "github.com/jhump/protoreflect/dynamic" + "github.com/golang/protobuf/jsonpb" //lint:ignore SA1019 we have to import these because some of their types appear in exported API + "github.com/golang/protobuf/proto" //lint:ignore SA1019 same as above + "github.com/jhump/protoreflect/desc" //lint:ignore SA1019 same as above + "github.com/jhump/protoreflect/dynamic" //lint:ignore SA1019 same as above "github.com/jhump/protoreflect/dynamic/grpcdynamic" "github.com/jhump/protoreflect/grpcreflect" "google.golang.org/grpc"