From c23f7dbae6a10e45edada1af6c52224fbb10088b Mon Sep 17 00:00:00 2001
From: Josh Humphries <jh@fullstory.com>
Date: Tue, 16 Oct 2018 18:12:19 -0400
Subject: [PATCH] make sure text format is indented and readable even for
 dynamic messages

---
 cmd/grpcurl/grpcurl.go | 21 +++++++++++++++++++--
 1 file changed, 19 insertions(+), 2 deletions(-)

diff --git a/cmd/grpcurl/grpcurl.go b/cmd/grpcurl/grpcurl.go
index f502a64..a1347b4 100644
--- a/cmd/grpcurl/grpcurl.go
+++ b/cmd/grpcurl/grpcurl.go
@@ -616,7 +616,7 @@ func (h *handler) OnReceiveResponse(resp proto.Message) {
 	}
 	respStr, err := h.formatter(resp)
 	if err != nil {
-		fail(err, "failed to generate JSON form of response message")
+		fail(err, "failed to generate %s form of response message", *format)
 	}
 	fmt.Fprintln(h.out, respStr)
 }
@@ -770,7 +770,24 @@ func (tf *textFormatter) format(m proto.Message) (string, error) {
 			return "", err
 		}
 	}
-	if err := proto.MarshalText(&buf, m); err != nil {
+
+	// If message implements MarshalText method (such as a *dynamic.Message),
+	// it won't get details about whether or not to format to text compactly
+	// or with indentation. So first see if the message also implements a
+	// MarshalTextIndent method and use that instead if available.
+	type indentMarshaler interface {
+		MarshalTextIndent() ([]byte, error)
+	}
+
+	if indenter, ok := m.(indentMarshaler); ok {
+		b, err := indenter.MarshalTextIndent()
+		if err != nil {
+			return "", err
+		}
+		if _, err := buf.Write(b); err != nil {
+			return "", err
+		}
+	} else if err := proto.MarshalText(&buf, m); err != nil {
 		return "", err
 	}