From d86529bb4f81964b9fb9396dadaf0dbdf72a1a01 Mon Sep 17 00:00:00 2001 From: Joshua Humphries Date: Thu, 15 Nov 2018 20:27:01 -0500 Subject: [PATCH] don't use TLS 1.3, which isn't quite right yet in Go tip (#66) --- grpcurl.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/grpcurl.go b/grpcurl.go index 5d69437..990761d 100644 --- a/grpcurl.go +++ b/grpcurl.go @@ -516,6 +516,9 @@ func ClientTransportCredentials(insecureSkipVerify bool, cacertFile, clientCertF // client certs. The serverCertFile and serverKeyFile must both not be blank. func ServerTransportCredentials(cacertFile, serverCertFile, serverKeyFile string, requireClientCerts bool) (credentials.TransportCredentials, error) { var tlsConf tls.Config + // TODO(jh): Remove this line once https://github.com/golang/go/issues/28779 is fixed + // in Go tip. Until then, the recently merged TLS 1.3 support breaks the TLS tests. + tlsConf.MaxVersion = tls.VersionTLS12 // Load the server certificates from disk certificate, err := tls.LoadX509KeyPair(serverCertFile, serverKeyFile)