enable full linter across the codebase (#9620)

enable linter using golangci-lint across
codebase to run a bunch of linters together,
we shall enable new linters as we fix more
things the codebase.

This PR fixes the first stage of this
cleanup.

pkg/s3select/csv/args.go

@@ -26,9 +26,8 @@ import (
 )
 
 const (
-	none   = "none"
-	use    = "use"
-	ignore = "ignore"
+	none = "none"
+	use  = "use"
 
 	defaultRecordDelimiter      = "\n"
 	defaultFieldDelimiter       = ","
@@ -36,7 +35,6 @@ const (
 	defaultQuoteEscapeCharacter = `"`
 	defaultCommentCharacter     = "#"
 
-	always   = "always"
 	asneeded = "asneeded"
 )
 

pkg/s3select/csv/errors.go

@@ -43,24 +43,6 @@ func (err *s3Error) Error() string {
 	return err.message
 }
 
-func errInvalidFileHeaderInfo(err error) *s3Error {
-	return &s3Error{
-		code:       "InvalidFileHeaderInfo",
-		message:    "The FileHeaderInfo is invalid. Only NONE, USE, and IGNORE are supported.",
-		statusCode: 400,
-		cause:      err,
-	}
-}
-
-func errInvalidQuoteFields(err error) *s3Error {
-	return &s3Error{
-		code:       "InvalidQuoteFields",
-		message:    "The QuoteFields is invalid. Only ALWAYS and ASNEEDED are supported.",
-		statusCode: 400,
-		cause:      err,
-	}
-}
-
 func errCSVParsingError(err error) *s3Error {
 	return &s3Error{
 		code:       "CSVParsingError",

pkg/s3select/select_test.go

@@ -996,7 +996,7 @@ func TestParquetInput(t *testing.T) {
 					offset = fi.Size() + offset
 				}
 
-				if _, err = file.Seek(offset, os.SEEK_SET); err != nil {
+				if _, err = file.Seek(offset, io.SeekStart); err != nil {
 					return nil, err
 				}
 

pkg/s3select/simdj/errors.go

@@ -45,15 +45,6 @@ func (err *s3Error) Error() string {
 	return err.message
 }
 
-func errInvalidJSONType(err error) *s3Error {
-	return &s3Error{
-		code:       "InvalidJsonType",
-		message:    "The JsonType is invalid. Only DOCUMENT and LINES are supported.",
-		statusCode: 400,
-		cause:      err,
-	}
-}
-
 func errJSONParsingError(err error) *s3Error {
 	return &s3Error{
 		code:       "JSONParsingError",

pkg/s3select/sql/value_test.go

@@ -160,9 +160,6 @@ func TestValue_Equals(t *testing.T) {
 }
 
 func TestValue_CSVString(t *testing.T) {
-	type fields struct {
-		value interface{}
-	}
 	type test struct {
 		name    string
 		want    string