feat: add internal/bucket/cors CORS config type and matching

Signed-off-by: h5vx <h5v@protonmail.com>
2026-11-05 07:12:03 +03:00 · 2026-08-25 16:50:30 +05:00
parent f2520f3346
commit 1c9a2431fe
2 changed files with 241 additions and 0 deletions
@@ -0,0 +1,91 @@
+// Copyright (c) 2015-2021 MinIO, Inc.
+//
+// This file is part of MinIO Object Storage stack
+//
+// This program is free software: you can redistribute it and/or modify
+// it under the terms of the GNU Affero General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// This program is distributed in the hope that it will be useful
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU Affero General Public License for more details.
+//
+// You should have received a copy of the GNU Affero General Public License
+// along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+package cors
+
+import (
+	"strings"
+	"testing"
+)
+
+const sampleCORS = `<CORSConfiguration>
+  <CORSRule>
+    <ID>rule1</ID>
+    <AllowedOrigin>http://www.example.com</AllowedOrigin>
+    <AllowedOrigin>https://*.example.org</AllowedOrigin>
+    <AllowedMethod>GET</AllowedMethod>
+    <AllowedMethod>PUT</AllowedMethod>
+    <AllowedHeader>x-amz-*</AllowedHeader>
+    <ExposeHeader>ETag</ExposeHeader>
+    <MaxAgeSeconds>3000</MaxAgeSeconds>
+  </CORSRule>
+</CORSConfiguration>`
+
+func TestParseAndValidate(t *testing.T) {
+	c, err := ParseBucketCorsConfig(strings.NewReader(sampleCORS))
+	if err != nil {
+		t.Fatalf("parse failed: %v", err)
+	}
+	if err := c.Validate(); err != nil {
+		t.Fatalf("validate failed: %v", err)
+	}
+	if len(c.CORSRules) != 1 {
+		t.Fatalf("expected 1 rule, got %d", len(c.CORSRules))
+	}
+	if c.CORSRules[0].MaxAgeSeconds != 3000 {
+		t.Fatalf("MaxAgeSeconds mismatch: %d", c.CORSRules[0].MaxAgeSeconds)
+	}
+}
+
+func TestValidateRejections(t *testing.T) {
+	cases := map[string]string{
+		"bad method":    `<CORSConfiguration><CORSRule><AllowedOrigin>*</AllowedOrigin><AllowedMethod>TRACE</AllowedMethod></CORSRule></CORSConfiguration>`,
+		"no origin":     `<CORSConfiguration><CORSRule><AllowedMethod>GET</AllowedMethod></CORSRule></CORSConfiguration>`,
+		"no method":     `<CORSConfiguration><CORSRule><AllowedOrigin>*</AllowedOrigin></CORSRule></CORSConfiguration>`,
+		"negative age":  `<CORSConfiguration><CORSRule><AllowedOrigin>*</AllowedOrigin><AllowedMethod>GET</AllowedMethod><MaxAgeSeconds>-1</MaxAgeSeconds></CORSRule></CORSConfiguration>`,
+	}
+	for name, doc := range cases {
+		c, err := ParseBucketCorsConfig(strings.NewReader(doc))
+		if err != nil {
+			continue // parse-level rejection is acceptable
+		}
+		if err := c.Validate(); err == nil {
+			t.Errorf("%s: expected validation error, got nil", name)
+		}
+	}
+}
+
+func TestMatching(t *testing.T) {
+	c, _ := ParseBucketCorsConfig(strings.NewReader(sampleCORS))
+	rule, ok := c.MatchRule("https://api.example.org", "GET")
+	if !ok {
+		t.Fatal("expected origin+method to match")
+	}
+	if _, ok := c.MatchRule("http://evil.com", "GET"); ok {
+		t.Fatal("did not expect match for disallowed origin")
+	}
+	if _, ok := c.MatchRule("http://www.example.com", "DELETE"); ok {
+		t.Fatal("did not expect match for disallowed method")
+	}
+	allowed, ok := rule.FilterAllowedHeaders([]string{"x-amz-date", "x-amz-content-sha256"})
+	if !ok || len(allowed) != 2 {
+		t.Fatalf("expected both headers allowed via wildcard, got %v ok=%v", allowed, ok)
+	}
+	if _, ok := rule.FilterAllowedHeaders([]string{"authorization"}); ok {
+		t.Fatal("did not expect authorization to be allowed")
+	}
+}