astelm/minio
1
0
Fork 0
mirror of https://github.com/pgsty/minio.git synced 2026-07-22 13:40:22 +03:00
Code Issues Packages Projects Releases Wiki Activity

avoid overwriting metrics on success, save it in defer (#17780)

Browse Source
This commit is contained in:
Harshavardhana
2023-08-01 22:19:56 -07:00
committed by GitHub
parent 0153f96a20
commit 21cdd2bf5d
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cmd/xl-storage-disk-id-check.go
+5 -3
View File
@@ -275,9 +275,11 @@ func (p *xlStorageDiskIDCheck) DiskInfo(ctx context.Context, metrics bool) (info
si := p.updateStorageMetrics(storageMetricDiskInfo) si := p.updateStorageMetrics(storageMetricDiskInfo)
defer si(&err) defer si(&err)
if metrics { defer func() {
info.Metrics = p.getMetrics() if metrics {
} info.Metrics = p.getMetrics()
}
}()
if p.health.isFaulty() { if p.health.isFaulty() {
// if disk is already faulty return faulty for 'mc admin info' output and prometheus alerts. // if disk is already faulty return faulty for 'mc admin info' output and prometheus alerts.