mirror of
https://github.com/pgsty/minio.git
synced 2026-10-07 02:05:58 +03:00
fix: report a purged version as a delete marker only for stored markers
The exact-version purge path copies the looked-up DeleteMarker flag into the DELETE response so that removing a delete marker keeps its x-amz-delete-marker header. That flag is also set for a data version whose purge is pending, because the lookup exposes such a version as deleted for visibility. Retrying the purge after the replication configuration was removed therefore answered with x-amz-delete-marker: true and raised ObjectRemovedDeleteMarkerCreated for a data version. Only a stored marker carries no erasure layout; use that to decide the response identity. Found by the adversarial review of the purge change. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Feng Ruohang <rh@vonng.com>
This commit is contained in:
@@ -2199,8 +2199,10 @@ func (er erasureObjects) DeleteObject(ctx context.Context, bucket, object string
|
||||
oi := dfi.ToObjectInfo(bucket, object, opts.Versioned || opts.VersionSuspended)
|
||||
if purge {
|
||||
// Preserve the DELETE response's identity without reusing it as a disk
|
||||
// instruction to create a marker.
|
||||
oi.DeleteMarker = goi.DeleteMarker
|
||||
// instruction to create a marker. The lookup also exposes a data
|
||||
// version pending purge as deleted for visibility; only a stored
|
||||
// marker, which carries no erasure layout, is reported as one.
|
||||
oi.DeleteMarker = goi.DeleteMarker && goi.DataBlocks == 0
|
||||
}
|
||||
return oi, nil
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user