astelm/minio
1
0
Fork 0
mirror of https://github.com/pgsty/minio.git synced 2026-11-10 17:45:32 +03:00
Code Issues Packages Projects Releases Wiki Activity

Integrate scanner rejection contract regression

Browse Source 
Signed-off-by: Feng Ruohang <rh@vonng.com>
This commit is contained in:
Feng Ruohang
2026-11-03 22:56:05 +08:00
parent f83d02831c 374b9ce309
commit 3ddf83182f
1 changed files with 14 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cmd/erasure-server-pool-consistency_test.go
+14 -4
View File
@@ -522,10 +522,20 @@ func TestPoolsDeleteVersionSpecialCalls(t *testing.T) {
opts := ObjectOptions{Versioned: true, VersionID: oi.VersionID, InclFreeVersions: !expiration, Expiration: ExpirationOptions{Expire: expiration}} opts := ObjectOptions{Versioned: true, VersionID: oi.VersionID, InclFreeVersions: !expiration, Expiration: ExpirationOptions{Expire: expiration}}
_, err := z.DeleteObject(t.Context(), bucket, object, opts) _, err := z.DeleteObject(t.Context(), bucket, object, opts)
if expiration { if expiration {
// No lifecycle rule authorizes expiration. Preserve its existing // No rule authorizes expiration. Distinguish refusal from real
// version-not-found result, even with an unrelated unreadable pool. // absence, even with an unrelated unreadable pool, so a worker
if !isErrVersionNotFound(err) { // cannot acknowledge or replicate a purge that never happened.
t.Errorf("expiration changed its scanner contract: %v", err) if !errors.Is(err, errLifecycleNotApplicable) {
t.Errorf("expiration did not preserve its rejection: %v", err)
}
gr, err := z.serverPools[0].GetObjectNInfo(t.Context(), bucket, object, nil, nil, ObjectOptions{VersionID: oi.VersionID})
if err != nil {
t.Fatal(err)
}
data, err := io.ReadAll(gr)
gr.Close()
if err != nil || string(data) != "payload" || gr.ObjInfo.VersionID != oi.VersionID {
t.Errorf("rejected expiration changed the stored version: %v", err)
} }
} else if err != nil { } else if err != nil {
t.Errorf("free-version cleanup was forced through all-pool resolution: %v", err) t.Errorf("free-version cleanup was forced through all-pool resolution: %v", err)