astelm/minio
1
0
Fork 0
mirror of https://github.com/pgsty/minio.git synced 2026-11-01 13:22:02 +03:00
Code Issues Packages Projects Releases Wiki Activity

test(replication): satisfy diagnostic regression style checks

Browse Source 
Signed-off-by: Feng Ruohang <rh@vonng.com>
This commit is contained in:
Feng Ruohang
2026-09-12 17:17:18 +08:00
parent fcbb93e895
commit 461e9a7210
2 changed files with 12 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cmd/site-replication-metadata-gate_test.go
+4 -2
View File
@@ -279,8 +279,10 @@ func TestBucketMetadataInitialSyncPhysicalCreated(t *testing.T) {
defer peer.Close() defer peer.Close()
// Exercise the complete outgoing sync sequence with real source // Exercise the complete outgoing sync sequence with real source
// storage. This peer acknowledges RPCs; it is not a second ObjectLayer. // storage. This peer acknowledges RPCs; it is not a second ObjectLayer.
c := &SiteReplicationSys{enabled: true, state: srState{ServiceAccountAccessKey: serviceCred.AccessKey, c := &SiteReplicationSys{enabled: true, state: srState{
Peers: map[string]madmin.PeerInfo{"initial-peer": {DeploymentID: "initial-peer", Endpoint: peer.URL}}}} ServiceAccountAccessKey: serviceCred.AccessKey,
Peers: map[string]madmin.PeerInfo{"initial-peer": {DeploymentID: "initial-peer", Endpoint: peer.URL}},
}}
if err := c.syncToAllPeers(ctx, madmin.SRAddOptions{}); err != nil { if err := c.syncToAllPeers(ctx, madmin.SRAddOptions{}); err != nil {
t.Fatal(err) t.Fatal(err)
} }
cmd/site-replication-metadata-heal_test.go
+8 -5
View File
@@ -89,11 +89,12 @@ func TestHealBucketConfigDiagnostics(t *testing.T) {
defer capture.mu.Unlock() defer capture.mu.Unlock()
var unreachable, peerError int var unreachable, peerError int
for _, line := range capture.lines { for _, line := range capture.lines {
if strings.Contains(line, "bucket metadata replication: unreachable") { switch {
case strings.Contains(line, "bucket metadata replication: unreachable"):
unreachable++ unreachable++
} else if strings.Contains(line, "bucket metadata replication: peer-error") { case strings.Contains(line, "bucket metadata replication: peer-error"):
peerError++ peerError++
} else { default:
t.Fatalf("unexpected diagnostic: %s", line) t.Fatalf("unexpected diagnostic: %s", line)
} }
if !strings.HasPrefix(line, "WARNING:") { if !strings.HasPrefix(line, "WARNING:") {
@@ -135,11 +136,13 @@ func TestHealBucketConfigWithoutSourceDiagnostics(t *testing.T) {
// and neither local storage nor the recording peer may be written. // and neither local storage nor the recording peer may be written.
name := bucket + "-" + tc.name name := bucket + "-" + tc.name
local := globalDeploymentID() local := globalDeploymentID()
info := srStatusInfo{Sites: map[string]madmin.PeerInfo{local: {}, "metadata-peer": {}, "unreachable": {}}, info := srStatusInfo{
Sites: map[string]madmin.PeerInfo{local: {}, "metadata-peer": {}, "unreachable": {}},
BucketStats: map[string]map[string]srBucketStatsSummary{name: { BucketStats: map[string]map[string]srBucketStatsSummary{name: {
local: bucketConfigTestInfo(name, bucketTaggingConfig, tc.data, tc.at, tc.created), local: bucketConfigTestInfo(name, bucketTaggingConfig, tc.data, tc.at, tc.created),
"metadata-peer": {}, "metadata-peer": {},
}}} }},
}
for range 2 { for range 2 {
if err := globalSiteReplicationSys.healBucketConfig(t.Context(), name, bucketTaggingConfig, info); err != nil { if err := globalSiteReplicationSys.healBucketConfig(t.Context(), name, bucketTaggingConfig, info); err != nil {
t.Fatal(err) t.Fatal(err)