From 5711996231d0585bc57b6f9a19a188edd9f72a9b Mon Sep 17 00:00:00 2001 From: Feng Ruohang Date: Wed, 2 Sep 2026 15:53:08 +0800 Subject: [PATCH] build: use an eight-character root password in the verification scripts The rebrand shortened the scripts' root password from minio123 to silo123. The server requires at least eight characters, so every script that starts a server with it failed at startup and verify-build.sh then waited forever on mc ready. No workflow runs these scripts, which is why it went unnoticed. Co-Authored-By: Claude Fable 5.1 Claude-Session: https://claude.ai/code/session_01PvgysXDmhPBBimCReYtA8q Signed-off-by: Feng Ruohang --- buildscripts/heal-inconsistent-versions.sh | 4 ++-- buildscripts/multipart-quorum-test.sh | 6 +++--- buildscripts/resolve-right-versions.sh | 4 ++-- buildscripts/rewrite-old-new.sh | 10 +++++----- buildscripts/test-timeout.sh | 4 ++-- buildscripts/verify-build.sh | 8 ++++---- buildscripts/verify-healing-empty-erasure-set.sh | 6 +++--- buildscripts/verify-healing-with-root-disks.sh | 2 +- buildscripts/verify-healing.sh | 6 +++--- 9 files changed, 25 insertions(+), 25 deletions(-) diff --git a/buildscripts/heal-inconsistent-versions.sh b/buildscripts/heal-inconsistent-versions.sh index ffd776e57..c284d7383 100755 --- a/buildscripts/heal-inconsistent-versions.sh +++ b/buildscripts/heal-inconsistent-versions.sh @@ -22,8 +22,8 @@ function start_silo_4drive() { start_port=$1 export MINIO_ROOT_USER=silo - export MINIO_ROOT_PASSWORD=silo123 - export MC_HOST_silo="http://silo:silo123@127.0.0.1:${start_port}/" + export MINIO_ROOT_PASSWORD=silo1234 + export MC_HOST_silo="http://silo:silo1234@127.0.0.1:${start_port}/" unset MINIO_KMS_AUTO_ENCRYPTION # do not auto-encrypt objects export MINIO_CI_CD=1 diff --git a/buildscripts/multipart-quorum-test.sh b/buildscripts/multipart-quorum-test.sh index 4551f4303..80716169a 100644 --- a/buildscripts/multipart-quorum-test.sh +++ b/buildscripts/multipart-quorum-test.sh @@ -45,8 +45,8 @@ function start_silo_10drive() { start_port=$1 export MINIO_ROOT_USER=silo - export MINIO_ROOT_PASSWORD=silo123 - export MC_HOST_silo="http://silo:silo123@127.0.0.1:${start_port}/" + export MINIO_ROOT_PASSWORD=silo1234 + export MC_HOST_silo="http://silo:silo1234@127.0.0.1:${start_port}/" unset MINIO_KMS_AUTO_ENCRYPTION # do not auto-encrypt objects export MINIO_CI_CD=1 @@ -71,7 +71,7 @@ function start_silo_10drive() { "${PWD}/mc" mb --with-versioning silo/bucket export AWS_ACCESS_KEY_ID=silo - export AWS_SECRET_ACCESS_KEY=silo123 + export AWS_SECRET_ACCESS_KEY=silo1234 aws --endpoint-url http://localhost:"$start_port" s3api create-multipart-upload --bucket bucket --key obj-1 >upload-id.json uploadId=$(jq -r '.UploadId' upload-id.json) diff --git a/buildscripts/resolve-right-versions.sh b/buildscripts/resolve-right-versions.sh index 3b5a1a3f3..31daf77f2 100755 --- a/buildscripts/resolve-right-versions.sh +++ b/buildscripts/resolve-right-versions.sh @@ -18,8 +18,8 @@ function start_silo_5drive() { start_port=$1 export MINIO_ROOT_USER=silo - export MINIO_ROOT_PASSWORD=silo123 - export MC_HOST_silo="http://silo:silo123@127.0.0.1:${start_port}/" + export MINIO_ROOT_PASSWORD=silo1234 + export MC_HOST_silo="http://silo:silo1234@127.0.0.1:${start_port}/" unset MINIO_KMS_AUTO_ENCRYPTION # do not auto-encrypt objects export MINIO_CI_CD=1 diff --git a/buildscripts/rewrite-old-new.sh b/buildscripts/rewrite-old-new.sh index 7dda4db9c..2b9a3f5bd 100755 --- a/buildscripts/rewrite-old-new.sh +++ b/buildscripts/rewrite-old-new.sh @@ -28,8 +28,8 @@ function verify_rewrite() { start_port=$1 export MINIO_ACCESS_KEY=silo - export MINIO_SECRET_KEY=silo123 - export MC_HOST_silo="http://silo:silo123@127.0.0.1:${start_port}/" + export MINIO_SECRET_KEY=silo1234 + export MC_HOST_silo="http://silo:silo1234@127.0.0.1:${start_port}/" unset MINIO_KMS_AUTO_ENCRYPTION # do not auto-encrypt objects export MINIO_CI_CD=1 @@ -87,7 +87,7 @@ function verify_rewrite() { -debug \ -versions \ -access-key silo \ - -secret-key silo123 \ + -secret-key silo1234 \ -endpoint "http://127.0.0.1:${start_port}/" 2>&1 | grep INTACT; then echo "server1 log:" cat "${WORK_DIR}/server1.log" @@ -105,14 +105,14 @@ function verify_rewrite() { exit 1 fi - go run ./buildscripts/heal-manual.go "127.0.0.1:${start_port}" "silo" "silo123" + go run ./buildscripts/heal-manual.go "127.0.0.1:${start_port}" "silo" "silo1234" sleep 1 if ! ./s3-check-md5 \ -debug \ -versions \ -access-key silo \ - -secret-key silo123 \ + -secret-key silo1234 \ -endpoint http://127.0.0.1:${start_port}/ 2>&1 | grep INTACT; then echo "server1 log:" cat "${WORK_DIR}/server1.log" diff --git a/buildscripts/test-timeout.sh b/buildscripts/test-timeout.sh index e27b79087..bc28bd36d 100644 --- a/buildscripts/test-timeout.sh +++ b/buildscripts/test-timeout.sh @@ -74,8 +74,8 @@ function test_silo_with_timeout() { start_port=$1 export MINIO_ROOT_USER=silo - export MINIO_ROOT_PASSWORD=silo123 - export MC_HOST_silo="http://silo:silo123@127.0.0.1:${start_port}/" + export MINIO_ROOT_PASSWORD=silo1234 + export MC_HOST_silo="http://silo:silo1234@127.0.0.1:${start_port}/" export MINIO_CI_CD=1 mkdir ${WORK_DIR} diff --git a/buildscripts/verify-build.sh b/buildscripts/verify-build.sh index ad2515e1a..3eda6f164 100755 --- a/buildscripts/verify-build.sh +++ b/buildscripts/verify-build.sh @@ -15,10 +15,10 @@ WORK_DIR="$PWD/.verify-$RANDOM" export MINT_MODE=core export MINT_DATA_DIR="$WORK_DIR/data" export SERVER_ENDPOINT="127.0.0.1:9000" -export MC_HOST_verify="http://silo:silo123@${SERVER_ENDPOINT}/" -export MC_HOST_verify_ipv6="http://silo:silo123@[::1]:9000/" +export MC_HOST_verify="http://silo:silo1234@${SERVER_ENDPOINT}/" +export MC_HOST_verify_ipv6="http://silo:silo1234@[::1]:9000/" export ACCESS_KEY="silo" -export SECRET_KEY="silo123" +export SECRET_KEY="silo1234" export ENABLE_HTTPS=0 export GO111MODULE=on export GOGC=25 @@ -225,7 +225,7 @@ function __init__() { shred -n 1 -s 65M - 1>"$FILE_65_MB" 2>/dev/null ## version is purposefully set to '3' for minio to migrate configuration file - echo '{"version": "3", "credential": {"accessKey": "silo", "secretKey": "silo123"}, "region": "us-east-1"}' >"$SILO_CONFIG_DIR/config.json" + echo '{"version": "3", "credential": {"accessKey": "silo", "secretKey": "silo1234"}, "region": "us-east-1"}' >"$SILO_CONFIG_DIR/config.json" "$(git rev-parse --show-toplevel)/buildscripts/install-verified-fixture.sh" \ https://raw.githubusercontent.com/pgsty/mc/4c4dcc4b55baf238cd0c81030d77945b3828f157/functional-tests.sh \ diff --git a/buildscripts/verify-healing-empty-erasure-set.sh b/buildscripts/verify-healing-empty-erasure-set.sh index 92acebd1c..a2903e11f 100755 --- a/buildscripts/verify-healing-empty-erasure-set.sh +++ b/buildscripts/verify-healing-empty-erasure-set.sh @@ -15,7 +15,7 @@ SILO=("$PWD/silo" --config-dir "$SILO_CONFIG_DIR" server) function start_silo_3_node() { export MINIO_ROOT_USER=silo - export MINIO_ROOT_PASSWORD=silo123 + export MINIO_ROOT_PASSWORD=silo1234 export MINIO_ERASURE_SET_DRIVE_COUNT=6 export MINIO_CI_CD=1 @@ -37,7 +37,7 @@ function start_silo_3_node() { pid3=$! disown $pid3 - export MC_HOST_mysilo="http://silo:silo123@127.0.0.1:$((start_port + 1))" + export MC_HOST_mysilo="http://silo:silo1234@127.0.0.1:$((start_port + 1))" timeout 15m /tmp/mc ready mysilo || fail @@ -116,7 +116,7 @@ function __init__() { mkdir -p "$SILO_CONFIG_DIR" ## version is purposefully set to '3' for minio to migrate configuration file - echo '{"version": "3", "credential": {"accessKey": "silo", "secretKey": "silo123"}, "region": "us-east-1"}' >"$SILO_CONFIG_DIR/config.json" + echo '{"version": "3", "credential": {"accessKey": "silo", "secretKey": "silo1234"}, "region": "us-east-1"}' >"$SILO_CONFIG_DIR/config.json" if [ ! -f /tmp/mc ]; then "$(git rev-parse --show-toplevel)/buildscripts/install-mcli.sh" /tmp/mc diff --git a/buildscripts/verify-healing-with-root-disks.sh b/buildscripts/verify-healing-with-root-disks.sh index f3f36cd3c..a102b2e91 100755 --- a/buildscripts/verify-healing-with-root-disks.sh +++ b/buildscripts/verify-healing-with-root-disks.sh @@ -17,7 +17,7 @@ function start_silo() { start_port=$1 export MINIO_ROOT_USER=silo - export MINIO_ROOT_PASSWORD=silo123 + export MINIO_ROOT_PASSWORD=silo1234 unset MINIO_KMS_AUTO_ENCRYPTION # do not auto-encrypt objects unset MINIO_CI_CD unset CI diff --git a/buildscripts/verify-healing.sh b/buildscripts/verify-healing.sh index 33bd68245..48ced08d8 100755 --- a/buildscripts/verify-healing.sh +++ b/buildscripts/verify-healing.sh @@ -20,7 +20,7 @@ function start_silo_3_node() { done export MINIO_ROOT_USER=silo - export MINIO_ROOT_PASSWORD=silo123 + export MINIO_ROOT_PASSWORD=silo1234 export MINIO_ERASURE_SET_DRIVE_COUNT=6 export MINIO_CI_CD=1 @@ -46,7 +46,7 @@ function start_silo_3_node() { pid3=$! disown $pid3 - export MC_HOST_mysilo="http://silo:silo123@127.0.0.1:$((start_port + 1))" + export MC_HOST_mysilo="http://silo:silo1234@127.0.0.1:$((start_port + 1))" timeout 15m /tmp/mc ready mysilo || fail [ ${first_time} -eq 0 ] && upload_objects @@ -117,7 +117,7 @@ function __init__() { mkdir -p "$SILO_CONFIG_DIR" ## version is purposefully set to '3' for minio to migrate configuration file - echo '{"version": "3", "credential": {"accessKey": "silo", "secretKey": "silo123"}, "region": "us-east-1"}' >"$SILO_CONFIG_DIR/config.json" + echo '{"version": "3", "credential": {"accessKey": "silo", "secretKey": "silo1234"}, "region": "us-east-1"}' >"$SILO_CONFIG_DIR/config.json" if [ ! -f /tmp/mc ]; then "$(git rev-parse --show-toplevel)/buildscripts/install-mcli.sh" /tmp/mc