mirror of
https://github.com/pgsty/minio.git
synced 2026-07-23 22:16:15 +03:00
This patch uses a technique where in a retryable storage before object layer initialization has a higher delay and waits for longer period upto 4 times with time unit of seconds. And uses another set of configuration after the disks have been formatted, i.e use a lower retry backoff rate and retrying only once per 5 millisecond. Network IO error count is reduced to a lower value i.e 256 before we reject the disk completely. This is done so that combination of retry logic and total error count roughly come to around 2.5secs which is when we basically take the disk offline completely. NOTE: This patch doesn't fix the issue of what if the disk is completely dead and comes back again after the initialization. Such a mutating state requires a change in our startup sequence which will be done subsequently. This is an interim fix to alleviate users from these issues.
This commit is contained in:
+26
-2
@@ -311,16 +311,40 @@ func waitForFormatDisks(firstDisk bool, endpoints []*url.URL, storageDisks []Sto
|
||||
if storageDisks == nil {
|
||||
return nil, errInvalidArgument
|
||||
}
|
||||
|
||||
// Retryable disks before formatting, we need to have a larger
|
||||
// retry window so that we wait enough amount of time before
|
||||
// the disks come online.
|
||||
retryDisks := make([]StorageAPI, len(storageDisks))
|
||||
for i, storage := range storageDisks {
|
||||
retryDisks[i] = &retryStorage{
|
||||
remoteStorage: storage,
|
||||
maxRetryAttempts: globalStorageInitRetryThreshold,
|
||||
retryUnit: time.Second,
|
||||
retryCap: time.Second * 30, // 30 seconds.
|
||||
}
|
||||
}
|
||||
|
||||
// Start retry loop retrying until disks are formatted properly, until we have reached
|
||||
// a conditional quorum of formatted disks.
|
||||
err = retryFormattingDisks(firstDisk, endpoints, storageDisks)
|
||||
err = retryFormattingDisks(firstDisk, endpoints, retryDisks)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
|
||||
// Initialize the disk into a formatted disks wrapper.
|
||||
formattedDisks = make([]StorageAPI, len(storageDisks))
|
||||
for i, storage := range storageDisks {
|
||||
formattedDisks[i] = &retryStorage{storage}
|
||||
// After formatting is done we need a smaller time
|
||||
// window and lower retry value before formatting.
|
||||
formattedDisks[i] = &retryStorage{
|
||||
remoteStorage: storage,
|
||||
maxRetryAttempts: globalStorageRetryThreshold,
|
||||
retryUnit: time.Millisecond,
|
||||
retryCap: time.Millisecond * 5, // 5 milliseconds.
|
||||
}
|
||||
}
|
||||
|
||||
// Success.
|
||||
return formattedDisks, nil
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user