astelm/minio
1
0
Fork 0
mirror of https://github.com/pgsty/minio.git synced 2026-11-01 05:12:07 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix: reject missing remote checksums on federated copies

Browse Source 
Signed-off-by: Feng Ruohang <rh@vonng.com>
This commit is contained in:
Feng Ruohang
2026-09-08 13:05:45 +08:00
parent 95e7a190b3
commit 885bd2c20a
2 changed files with 46 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cmd/object-handlers.go
+6 -7
View File
@@ -1958,15 +1958,14 @@ func (api objectAPIHandlers) CopyObjectHandler(w http.ResponseWriter, r *http.Re
objInfo.UserDefined = cloneMSS(opts.UserMetadata)
objInfo.ETag = remoteObjInfo.ETag
objInfo.ModTime = remoteObjInfo.LastModified
// Bind the checksum the remote computed for this exact write into the
// response, matching the local CopyObject path and the federated
// UploadPartCopy repair in #72. A malformed or absent remote value
// leaves objInfo.Checksum unset, so an ordinary copy returns none.
// Do not acknowledge a requested checksum the remote did not return.
if wantChecksumType.IsSet() {
if cs := hash.NewChecksumWithType(wantChecksumType,
federatedChecksumValue(wantChecksumType, remoteObjInfo)); cs != nil {
objInfo.Checksum = cs.AppendTo(nil, nil)
cs := hash.NewChecksumWithType(wantChecksumType, federatedChecksumValue(wantChecksumType, remoteObjInfo))
if cs == nil {
writeErrorResponse(ctx, w, errorCodes.ToAPIErr(ErrInternalError), r.URL)
return
}
objInfo.Checksum = cs.AppendTo(nil, nil)
}
} else {
os = newObjSweeper(dstBucket, dstObject).WithVersioning(dstOpts.Versioned, dstOpts.VersionSuspended)