Relax runtime requirement do not fail, print warning (#6017)

This commit is contained in:
Harshavardhana
2018-06-05 20:55:12 -07:00
committed by Nitish Tiwari
parent 3143454982
commit 9d41051e91
2 changed files with 17 additions and 22 deletions
+14 -18
View File
@@ -1,5 +1,5 @@
/*
* Minio Cloud Storage, (C) 2017 Minio, Inc.
* Minio Cloud Storage, (C) 2017, 2018 Minio, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -17,34 +17,30 @@
package main
import (
"fmt"
"testing"
)
func TestCheckGoVersion(t *testing.T) {
// Test success cases.
testCases := []struct {
version string
expectedErr error
version string
success bool
}{
{minGoVersion, nil},
{"1.6.8", fmt.Errorf("Minio is not compiled by Go >= 1.9.4. Please recompile accordingly")},
{"1.5", fmt.Errorf("Minio is not compiled by Go >= 1.9.4. Please recompile accordingly")},
{"0.1", fmt.Errorf("Minio is not compiled by Go >= 1.9.4. Please recompile accordingly")},
{".1", fmt.Errorf("Malformed version: .1")},
{"somejunk", fmt.Errorf("Malformed version: somejunk")},
{minGoVersion, true},
{"1.6.8", false},
{"1.5", false},
{"0.1", false},
{".1", false},
{"somejunk", false},
}
for _, testCase := range testCases {
err := checkGoVersion(testCase.version)
if testCase.expectedErr == nil {
if err != nil {
t.Fatalf("expected: %v, got: %v", testCase.expectedErr, err)
}
} else if err == nil {
t.Fatalf("expected: %v, got: %v", testCase.expectedErr, err)
} else if testCase.expectedErr.Error() != err.Error() {
t.Fatalf("expected: %v, got: %v", testCase.expectedErr, err)
if err != nil && testCase.success {
t.Fatalf("Test %v, expected: success, got: %v", testCase, err)
}
if err == nil && !testCase.success {
t.Fatalf("Test %v, expected: failure, got: success", testCase)
}
}
}