mirror of
https://github.com/pgsty/minio.git
synced 2026-11-10 17:45:32 +03:00
fix(ilm): report refused purges of all versions, and account their keys
An expiry of all versions of a key purges exactly that key, and the purge can refuse it or stop early. Those outcomes were hard to see, and the scanner reported a key it had queued as if it were already gone. - Refusals and failures of a purge are counted in expiry_incomplete_total with their own reasons: tier_unsupported (a version is in a remote tier), budget (stopped after progress; the next expiry continues), changed (the latest version a batch matched changed) and history_unavailable. They are traced with the reason and send no removal event. A partial purge keeps its audit record, now with the reason. A tier refusal is also logged, once per key and hour, in words. - A drive that cannot be read or decoded during the purge's own drive check now returns errDeleteAllHistoryUnavailable, which names the cause and stays a write quorum error (503) for API callers. - The scanner does not queue an expiry of all versions whose latest version is hot when the pool holds a version in a remote tier: the purge would refuse it each cycle. It counts each such observation as tier_unsupported_skipped, once per drive scanner and cycle. A tiered version only another pool holds is unknown here, so the purge still decides; a transitioned latest version keeps the transitioned expiry. The tier predicate is shared with the purge's own check, for FileInfo and ObjectInfo, and excludes free versions. - The scanner accounts every version of a key under an expiry of all versions at its size, queued or not, instead of as already removed. Usage, and so hard quota, drops after a fresh scan of the subtree once the purge succeeded. The alerts on many or large versions count the versions of a key that is not queued. - A lifecycle expiry never deletes a prefix: DeleteObject refuses DeletePrefix with Expiration.Expire as InvalidArgument. No caller sends it since expiries of all versions became purges; a force delete of a prefix is unchanged. Not done from the plan: queuing an MRF heal per version when a drive's xl.meta fails to decode. Object heal does not rewrite metadata that fails its CRC check (it reports the drive as unknown and skips it), so those heals would not repair the drive. Such a key stays refused until its metadata on that drive is repaired. Tests: TestPurgeAllVersionsRefusalReasons, TestPurgeAllVersionsRefusesCorruptDrive, TestScannerSkipsDeleteAllForTieredKey and TestPoolsDeleteObjectRejectsExpirePrefix are new. Tests that expected the scanner to queue a refused purge, the predictive accounting, or the old prefix options are converted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Feng Ruohang <rh@vonng.com>
This commit is contained in:
@@ -33,11 +33,23 @@ import (
|
||||
// could not be read, or another error. It is counted by reason, traced with
|
||||
// the reason, and, unless it was refused, audited and logged. It never sends
|
||||
// a removal notification: what it addressed is still there.
|
||||
//
|
||||
// An expiry of all versions of a key can also be refused because a version
|
||||
// is in a remote tier, or because the latest version changed since a batch
|
||||
// matched it, and it can stop at its budget after it removed some versions.
|
||||
const (
|
||||
ilmIncompleteNotApplicable = "not_applicable"
|
||||
ilmIncompleteLocked = "locked"
|
||||
ilmIncompleteHistoryUnavailable = "history_unavailable"
|
||||
ilmIncompleteError = "error"
|
||||
ilmIncompleteTierUnsupported = "tier_unsupported"
|
||||
ilmIncompleteBudget = "budget"
|
||||
ilmIncompleteChanged = "changed"
|
||||
// ilmIncompleteTierSkipped counts the scanner's observations of a key
|
||||
// whose expiry of all versions it did not queue, because a version it
|
||||
// holds is in a remote tier and the purge would refuse it. Each drive's
|
||||
// scanner of the key observes it, once per cycle.
|
||||
ilmIncompleteTierSkipped = "tier_unsupported_skipped"
|
||||
)
|
||||
|
||||
// ilmIncompleteReasons are the reasons expiry_incomplete_total counts, a
|
||||
@@ -47,6 +59,10 @@ var ilmIncompleteReasons = []string{
|
||||
ilmIncompleteLocked,
|
||||
ilmIncompleteHistoryUnavailable,
|
||||
ilmIncompleteError,
|
||||
ilmIncompleteTierUnsupported,
|
||||
ilmIncompleteBudget,
|
||||
ilmIncompleteChanged,
|
||||
ilmIncompleteTierSkipped,
|
||||
}
|
||||
|
||||
// ilmIncompleteStats counts incomplete ILM expiries by reason.
|
||||
@@ -85,6 +101,12 @@ func ilmExpiryNotDone(err error) (reason string, counted bool) {
|
||||
switch {
|
||||
case err == nil || isErrObjectNotFound(err) || isErrVersionNotFound(err):
|
||||
return "", false
|
||||
case errors.Is(err, errDeleteAllTiered):
|
||||
return ilmIncompleteTierUnsupported, true
|
||||
case errors.Is(err, errDeleteAllChanged):
|
||||
return ilmIncompleteChanged, true
|
||||
case errors.Is(err, errDeleteAllBudget):
|
||||
return ilmIncompleteBudget, true
|
||||
case errors.Is(err, errLifecycleNotApplicable):
|
||||
return ilmIncompleteNotApplicable, true
|
||||
}
|
||||
@@ -101,7 +123,11 @@ func ilmExpiryNotDone(err error) (reason string, counted bool) {
|
||||
// ilmExpiryRefused reports whether reason is a refusal, which changes
|
||||
// nothing, rather than a failure.
|
||||
func ilmExpiryRefused(reason string) bool {
|
||||
return reason == ilmIncompleteNotApplicable || reason == ilmIncompleteLocked
|
||||
switch reason {
|
||||
case ilmIncompleteNotApplicable, ilmIncompleteLocked, ilmIncompleteTierUnsupported, ilmIncompleteChanged:
|
||||
return true
|
||||
}
|
||||
return false
|
||||
}
|
||||
|
||||
// reportILMExpiryNotDone reports an ILM expiry of oi that ended with err. It
|
||||
|
||||
Reference in New Issue
Block a user