remove older deploymentID fix behavior to speed up startup (#19497)

since mid 2018 we do not have any deployments
without deployment-id, it is time to put this
code to rest, this PR removes this old code as
its no longer valuable.

on setups with 1000's of drives these are all
quite expensive operations.

cmd/storage-rest-client.go

@@ -31,6 +31,7 @@ import (
 	"strconv"
 	"strings"
 	"sync"
+	"sync/atomic"
 	"time"
 
 	"github.com/minio/madmin-go/v3"
@@ -155,12 +156,10 @@ func toStorageErr(err error) error {
 
 // Abstracts a remote disk.
 type storageRESTClient struct {
-	endpoint    Endpoint
-	restClient  *rest.Client
-	gridConn    *grid.Subroute
-	diskID      string
-	formatData  []byte
-	formatMutex sync.RWMutex
+	endpoint   Endpoint
+	restClient *rest.Client
+	gridConn   *grid.Subroute
+	diskID     atomic.Pointer[string]
 
 	diskInfoCache *cachevalue.Cache[DiskInfo]
 }
@@ -170,14 +169,13 @@ func (client *storageRESTClient) GetDiskLoc() (poolIdx, setIdx, diskIdx int) {
 	return client.endpoint.PoolIdx, client.endpoint.SetIdx, client.endpoint.DiskIdx
 }
 
-// Wrapper to restClient.Call to handle network errors, in case of network error the connection is makred disconnected
-// permanently. The only way to restore the storage connection is at the xl-sets layer by xlsets.monitorAndConnectEndpoints()
-// after verifying format.json
+// Wrapper to restClient.Call to handle network errors, in case of network error the connection is disconnected
+// and a healthcheck routine gets invoked that would reconnect.
 func (client *storageRESTClient) call(ctx context.Context, method string, values url.Values, body io.Reader, length int64) (io.ReadCloser, error) {
 	if values == nil {
 		values = make(url.Values)
 	}
-	values.Set(storageRESTDiskID, client.diskID)
+	values.Set(storageRESTDiskID, *client.diskID.Load())
 	respBody, err := client.restClient.Call(ctx, method, values, body, length)
 	if err != nil {
 		return nil, toStorageErr(err)
@@ -222,7 +220,7 @@ func (client *storageRESTClient) NSScanner(ctx context.Context, cache dataUsageC
 	defer xioutil.SafeClose(updates)
 
 	st, err := storageNSScannerRPC.Call(ctx, client.gridConn, &nsScannerOptions{
-		DiskID:   client.diskID,
+		DiskID:   *client.diskID.Load(),
 		ScanMode: int(scanMode),
 		Cache:    &cache,
 	})
@@ -252,14 +250,6 @@ func (client *storageRESTClient) NSScanner(ctx context.Context, cache dataUsageC
 	return *final, nil
 }
 
-func (client *storageRESTClient) SetFormatData(b []byte) {
-	if client.IsOnline() {
-		client.formatMutex.Lock()
-		client.formatData = b
-		client.formatMutex.Unlock()
-	}
-}
-
 func (client *storageRESTClient) GetDiskID() (string, error) {
 	if !client.IsOnline() {
 		// make sure to check if the disk is offline, since the underlying
@@ -274,11 +264,11 @@ func (client *storageRESTClient) GetDiskID() (string, error) {
 	// a cached value - caller should make sure to use this
 	// function on a fresh disk or make sure to look at the error
 	// from a different networked call to validate the GetDiskID()
-	return client.diskID, nil
+	return *client.diskID.Load(), nil
 }
 
 func (client *storageRESTClient) SetDiskID(id string) {
-	client.diskID = id
+	client.diskID.Store(&id)
 }
 
 func (client *storageRESTClient) DiskInfo(ctx context.Context, opts DiskInfoOptions) (info DiskInfo, err error) {
@@ -296,7 +286,7 @@ func (client *storageRESTClient) DiskInfo(ctx context.Context, opts DiskInfoOpti
 		ctx, cancel := context.WithTimeout(ctx, 5*time.Second)
 		defer cancel()
 
-		opts.DiskID = client.diskID
+		opts.DiskID = *client.diskID.Load()
 
 		infop, err := storageDiskInfoRPC.Call(ctx, client.gridConn, &opts)
 		if err != nil {
@@ -315,7 +305,7 @@ func (client *storageRESTClient) DiskInfo(ctx context.Context, opts DiskInfoOpti
 			ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
 			defer cancel()
 
-			nopts := DiskInfoOptions{DiskID: client.diskID, Metrics: true}
+			nopts := DiskInfoOptions{DiskID: *client.diskID.Load(), Metrics: true}
 			infop, err := storageDiskInfoRPC.Call(ctx, client.gridConn, &nopts)
 			if err != nil {
 				return info, toStorageErr(err)
@@ -349,7 +339,7 @@ func (client *storageRESTClient) ListVols(ctx context.Context) (vols []VolInfo,
 // StatVol - get volume info over the network.
 func (client *storageRESTClient) StatVol(ctx context.Context, volume string) (vol VolInfo, err error) {
 	v, err := storageStatVolRPC.Call(ctx, client.gridConn, grid.NewMSSWith(map[string]string{
-		storageRESTDiskID: client.diskID,
+		storageRESTDiskID: *client.diskID.Load(),
 		storageRESTVolume: volume,
 	}))
 	if err != nil {
@@ -395,7 +385,7 @@ func (client *storageRESTClient) CreateFile(ctx context.Context, origvolume, vol
 
 func (client *storageRESTClient) WriteMetadata(ctx context.Context, origvolume, volume, path string, fi FileInfo) error {
 	_, err := storageWriteMetadataRPC.Call(ctx, client.gridConn, &MetadataHandlerParams{
-		DiskID:     client.diskID,
+		DiskID:     *client.diskID.Load(),
 		OrigVolume: origvolume,
 		Volume:     volume,
 		FilePath:   path,
@@ -406,7 +396,7 @@ func (client *storageRESTClient) WriteMetadata(ctx context.Context, origvolume,
 
 func (client *storageRESTClient) UpdateMetadata(ctx context.Context, volume, path string, fi FileInfo, opts UpdateMetadataOpts) error {
 	_, err := storageUpdateMetadataRPC.Call(ctx, client.gridConn, &MetadataHandlerParams{
-		DiskID:     client.diskID,
+		DiskID:     *client.diskID.Load(),
 		Volume:     volume,
 		FilePath:   path,
 		UpdateOpts: opts,
@@ -417,7 +407,7 @@ func (client *storageRESTClient) UpdateMetadata(ctx context.Context, volume, pat
 
 func (client *storageRESTClient) DeleteVersion(ctx context.Context, volume, path string, fi FileInfo, forceDelMarker bool, opts DeleteOptions) (err error) {
 	_, err = storageDeleteVersionRPC.Call(ctx, client.gridConn, &DeleteVersionHandlerParams{
-		DiskID:         client.diskID,
+		DiskID:         *client.diskID.Load(),
 		Volume:         volume,
 		FilePath:       path,
 		ForceDelMarker: forceDelMarker,
@@ -429,14 +419,8 @@ func (client *storageRESTClient) DeleteVersion(ctx context.Context, volume, path
 
 // WriteAll - write all data to a file.
 func (client *storageRESTClient) WriteAll(ctx context.Context, volume string, path string, b []byte) error {
-	// Specific optimization to avoid re-read from the drives for `format.json`
-	// in-case the caller is a network operation.
-	if volume == minioMetaBucket && path == formatConfigFile {
-		client.SetFormatData(b)
-	}
-
 	_, err := storageWriteAllRPC.Call(ctx, client.gridConn, &WriteAllHandlerParams{
-		DiskID:   client.diskID,
+		DiskID:   *client.diskID.Load(),
 		Volume:   volume,
 		FilePath: path,
 		Buf:      b,
@@ -447,7 +431,7 @@ func (client *storageRESTClient) WriteAll(ctx context.Context, volume string, pa
 // CheckParts - stat all file parts.
 func (client *storageRESTClient) CheckParts(ctx context.Context, volume string, path string, fi FileInfo) error {
 	_, err := storageCheckPartsRPC.Call(ctx, client.gridConn, &CheckPartsHandlerParams{
-		DiskID:   client.diskID,
+		DiskID:   *client.diskID.Load(),
 		Volume:   volume,
 		FilePath: path,
 		FI:       fi,
@@ -458,7 +442,7 @@ func (client *storageRESTClient) CheckParts(ctx context.Context, volume string,
 // RenameData - rename source path to destination path atomically, metadata and data file.
 func (client *storageRESTClient) RenameData(ctx context.Context, srcVolume, srcPath string, fi FileInfo, dstVolume, dstPath string, opts RenameOptions) (sign uint64, err error) {
 	params := RenameDataHandlerParams{
-		DiskID:    client.diskID,
+		DiskID:    *client.diskID.Load(),
 		SrcVolume: srcVolume,
 		SrcPath:   srcPath,
 		DstPath:   dstPath,
@@ -507,7 +491,7 @@ func (client *storageRESTClient) ReadVersion(ctx context.Context, origvolume, vo
 	// Use websocket when not reading data.
 	if !opts.ReadData {
 		resp, err := storageReadVersionRPC.Call(ctx, client.gridConn, grid.NewMSSWith(map[string]string{
-			storageRESTDiskID:     client.diskID,
+			storageRESTDiskID:     *client.diskID.Load(),
 			storageRESTOrigVolume: origvolume,
 			storageRESTVolume:     volume,
 			storageRESTFilePath:   path,
@@ -547,7 +531,7 @@ func (client *storageRESTClient) ReadXL(ctx context.Context, volume string, path
 	// Use websocket when not reading data.
 	if !readData {
 		resp, err := storageReadXLRPC.Call(ctx, client.gridConn, grid.NewMSSWith(map[string]string{
-			storageRESTDiskID:   client.diskID,
+			storageRESTDiskID:   *client.diskID.Load(),
 			storageRESTVolume:   volume,
 			storageRESTFilePath: path,
 			storageRESTReadData: "false",
@@ -577,20 +561,8 @@ func (client *storageRESTClient) ReadXL(ctx context.Context, volume string, path
 
 // ReadAll - reads all contents of a file.
 func (client *storageRESTClient) ReadAll(ctx context.Context, volume string, path string) ([]byte, error) {
-	// Specific optimization to avoid re-read from the drives for `format.json`
-	// in-case the caller is a network operation.
-	if volume == minioMetaBucket && path == formatConfigFile {
-		client.formatMutex.RLock()
-		formatData := make([]byte, len(client.formatData))
-		copy(formatData, client.formatData)
-		client.formatMutex.RUnlock()
-		if len(formatData) > 0 {
-			return formatData, nil
-		}
-	}
-
 	gridBytes, err := storageReadAllRPC.Call(ctx, client.gridConn, &ReadAllHandlerParams{
-		DiskID:   client.diskID,
+		DiskID:   *client.diskID.Load(),
 		Volume:   volume,
 		FilePath: path,
 	})
@@ -645,7 +617,7 @@ func (client *storageRESTClient) ListDir(ctx context.Context, origvolume, volume
 	values.Set(storageRESTDirPath, dirPath)
 	values.Set(storageRESTCount, strconv.Itoa(count))
 	values.Set(storageRESTOrigVolume, origvolume)
-	values.Set(storageRESTDiskID, client.diskID)
+	values.Set(storageRESTDiskID, *client.diskID.Load())
 
 	st, err := storageListDirRPC.Call(ctx, client.gridConn, values)
 	if err != nil {
@@ -661,7 +633,7 @@ func (client *storageRESTClient) ListDir(ctx context.Context, origvolume, volume
 // DeleteFile - deletes a file.
 func (client *storageRESTClient) Delete(ctx context.Context, volume string, path string, deleteOpts DeleteOptions) error {
 	_, err := storageDeleteFileRPC.Call(ctx, client.gridConn, &DeleteFileHandlerParams{
-		DiskID:   client.diskID,
+		DiskID:   *client.diskID.Load(),
 		Volume:   volume,
 		FilePath: path,
 		Opts:     deleteOpts,
@@ -726,7 +698,7 @@ func (client *storageRESTClient) DeleteVersions(ctx context.Context, volume stri
 // RenameFile - renames a file.
 func (client *storageRESTClient) RenameFile(ctx context.Context, srcVolume, srcPath, dstVolume, dstPath string) (err error) {
 	_, err = storageRenameFileRPC.Call(ctx, client.gridConn, &RenameFileHandlerParams{
-		DiskID:      client.diskID,
+		DiskID:      *client.diskID.Load(),
 		SrcVolume:   srcVolume,
 		SrcFilePath: srcPath,
 		DstVolume:   dstVolume,
@@ -855,6 +827,8 @@ func (client *storageRESTClient) Close() error {
 	return nil
 }
 
+var emptyDiskID = ""
+
 // Returns a storage rest client.
 func newStorageRESTClient(endpoint Endpoint, healthCheck bool, gm *grid.Manager) (*storageRESTClient, error) {
 	serverURL := &url.URL{
@@ -881,10 +855,12 @@ func newStorageRESTClient(endpoint Endpoint, healthCheck bool, gm *grid.Manager)
 	if conn == nil {
 		return nil, fmt.Errorf("unable to find connection for %s in targets: %v", endpoint.GridHost(), gm.Targets())
 	}
-	return &storageRESTClient{
+	client := &storageRESTClient{
 		endpoint:      endpoint,
 		restClient:    restClient,
 		gridConn:      conn,
 		diskInfoCache: cachevalue.New[DiskInfo](),
-	}, nil
+	}
+	client.SetDiskID(emptyDiskID)
+	return client, nil
 }