mirror of
https://github.com/pgsty/minio.git
synced 2026-08-08 23:33:30 +03:00
posix: Deprecate custom removeAll/mkdirAll implementations. (#4808)
Since go1.8 os.RemoveAll and os.MkdirAll both support long path names i.e UNC path on windows. The code we are carrying was directly borrowed from `pkg/os` package and doesn't need to be in our repo anymore. As a side affect this also addresses our codecoverage issue. Refer #4658
This commit is contained in:
committed by
Dee Koder
parent
b69aa9c4d0
commit
d864e00e24
@@ -20,6 +20,7 @@ package cmd
|
||||
|
||||
import (
|
||||
"io/ioutil"
|
||||
"os"
|
||||
"path"
|
||||
"syscall"
|
||||
"testing"
|
||||
@@ -58,7 +59,7 @@ func TestIsValidUmaskVol(t *testing.T) {
|
||||
if err = disk.MakeVol(testCase.volName); err != nil {
|
||||
t.Fatalf("Creating a volume failed with %s expected to pass.", err)
|
||||
}
|
||||
defer removeAll(tmpPath)
|
||||
defer os.RemoveAll(tmpPath)
|
||||
|
||||
// Stat to get permissions bits.
|
||||
st, err := osStat(path.Join(tmpPath, testCase.volName))
|
||||
@@ -101,7 +102,7 @@ func TestIsValidUmaskFile(t *testing.T) {
|
||||
t.Fatalf("Creating a volume failed with %s expected to pass.", err)
|
||||
}
|
||||
|
||||
defer removeAll(tmpPath)
|
||||
defer os.RemoveAll(tmpPath)
|
||||
|
||||
// Attempt to create a file to verify the permissions later.
|
||||
// AppendFile creates file with 0666 perms.
|
||||
|
||||
Reference in New Issue
Block a user