astelm/minio
1
0
Fork 0
mirror of https://github.com/pgsty/minio.git synced 2026-09-23 19:35:59 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix: return NoSuchBucket from listing shortcuts

Browse Source 
ListObjects shortcuts can return EOF before consulting storage, causing missing buckets to appear as empty listings. Verify bucket existence only on those shortcuts so the normal listing path retains the upstream fan-out optimization.

Cover ListObjects, ListObjectsV2, and ListObjectVersions at the object layer and verify HTTP 404 NoSuchBucket responses.

Fixes #32

Co-authored-by: Jason Lin <jason@JasondeMacBook-Air.local>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Feng Ruohang <rh@vonng.com>
This commit is contained in:
Feng Ruohang
2026-08-26 18:28:06 +08:00
parent 2e2377d1c6
commit e9c5340be9
3 changed files with 92 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cmd/object_api_suite_test.go
+39
View File
@@ -849,6 +849,45 @@ func testListObjectsTestsForNonExistentBucket(obj ObjectLayer, instanceType stri
}
}
// Wrapper for calling testListObjectsShortcutsForNonExistentBucket for both
// single-drive and multi-drive erasure setups.
func TestListObjectsShortcutsForNonExistentBucket(t *testing.T) {
ExecObjectLayerTest(t, testListObjectsShortcutsForNonExistentBucket)
}
// Tests validate that storage-bypassing list shortcuts do not mask a missing
// bucket as an empty result. The regular prefix case is a control for the
// storage-backed listing path.
func testListObjectsShortcutsForNonExistentBucket(obj ObjectLayer, instanceType string, t TestErrHandler) {
testCases := []struct {
name string
prefix string
marker string
maxKeys int
}{
{name: "slash-prefixed prefix", prefix: "/", maxKeys: 1000},
{name: "zero limit", prefix: "obj", maxKeys: 0},
{name: "marker outside prefix", prefix: "a", marker: "b", maxKeys: 1000},
{name: "regular prefix", prefix: "foo/bar", maxKeys: 1000},
}
for _, tc := range testCases {
_, err := obj.ListObjects(context.Background(), "bucket", tc.prefix, tc.marker, "", tc.maxKeys)
if !isErrBucketNotFound(err) {
t.Errorf("%s: ListObjects %s: expected BucketNotFound, got %v", instanceType, tc.name, err)
}
_, err = obj.ListObjectsV2(context.Background(), "bucket", tc.prefix, "", "", tc.maxKeys, false, tc.marker)
if !isErrBucketNotFound(err) {
t.Errorf("%s: ListObjectsV2 %s: expected BucketNotFound, got %v", instanceType, tc.name, err)
}
_, err = obj.ListObjectVersions(context.Background(), "bucket", tc.prefix, tc.marker, "", "", tc.maxKeys)
if !isErrBucketNotFound(err) {
t.Errorf("%s: ListObjectVersions %s: expected BucketNotFound, got %v", instanceType, tc.name, err)
}
}
}
// Wrapper for calling testNonExistentObjectInBucket for both Erasure and FS.
func TestNonExistentObjectInBucket(t *testing.T) {
ExecObjectLayerTest(t, testNonExistentObjectInBucket)