bbb64eaade
skip healing properly in the scanner when a drive is hotplugged ( #19939 )
...
skip healing properly in scanner when drive is hotplugged
due to how the state is passed around the SkipHealing
might not be the true state() of the system always, causing
a situation where we might healing from the scanner on the
same drive which is being. Due to this competing heals get
triggered that slow each other down.
2024-06-17 16:39:11 -07:00
7bd1d899bc
remove overzealous check during HEAD() ( #19940 )
...
due to a historic bug in CopyObject() where
an inlined object loses its metadata, the
check causes an incorrect fallback verifying
data-dir.
CopyObject() bug was fixed in ffa91f9794
2024-06-17 07:29:18 -07:00
c91d1ec2e3
fix: avoid metadata cache without data for all callers ( #19935 )
2024-06-14 06:28:35 -07:00
3bd3470d0b
Corrected names of node replication metrics ( #19932 )
...
Signed-off-by: Shubhendu Ram Tripathi <shubhendu@minio.io >
2024-06-13 15:26:54 -07:00
ba39ed9af7
loadUser() if not able to load() credential return error ( #19931 )
2024-06-13 15:26:38 -07:00
62e6dc950d
fix: do not update metadata cache upon headObject() ( #19929 )
2024-06-13 08:42:02 -07:00
ad04afe381
Fix SSEC multipart checksum replication ( #19915 )
...
* Multipart SSEC checksums were not transferred.
* Remove key mismatch logging. This key is user-controlled with SSEC.
* If the source is SSEC and the destination reports ErrSSEEncryptedObject,
assume replication is good.
2024-06-12 23:56:12 -07:00
d06b63d056
load credential for in-flights requests as singleflight ( #19920 )
...
avoid concurrent callers for LoadUser() to even initiate
object read() requests, if an on-going operation is in progress.
this avoids many callers hitting the drives causing I/O
spikes, also allows for loading credentials faster.
2024-06-12 13:47:56 -07:00
e3ac4035b9
decrement requests inqueue correctly after the request is processed ( #19918 )
2024-06-12 01:13:12 -07:00
d21b6daa49
fix: avoid crash when delete() returns an error in batch expiration ( #19909 )
2024-06-11 06:50:53 -07:00
55aa431578
fix: on windows avoid ':' as part of the object name ( #19907 )
...
fixes #18865
avoid-colon
2024-06-10 20:13:30 -07:00
614981e566
allow purge expired STS while loading credentials ( #19905 )
...
the reason for this is to avoid STS mappings to be
purged without a successful load of other policies,
and all the credentials only loaded successfully
are properly handled.
This also avoids unnecessary cache store which was
implemented earlier for optimization.
2024-06-10 11:45:50 -07:00
d2eed44c78
Fix replication checksum transfer ( #19906 )
...
Compression will be disabled by default if SSE-C is specified. So we can still honor SSE-C.
2024-06-10 10:40:33 -07:00
789cbc6fb2
heal: Dangling check to evaluate object parts separately ( #19797 )
2024-06-10 08:51:27 -07:00
0662c90b5c
fix: copyObject restore with a specific version, update test cases ( #19895 )
2024-06-10 08:50:49 -07:00
a2cab02554
Fix SSE-C checksums ( #19896 )
...
Compression will be disabled by default if SSE-C is specified. So we can still honor SSE-C.
2024-06-10 08:31:51 -07:00
6c7a21df6b
turn-off unexpected debug logging in List() calls ( #19903 )
2024-06-09 21:34:26 -07:00
29a25a538f
fix: make sure we list freeVersions like DEL marker with --versions ( #19878 )
...
freeVersions() was being incorrectly skipped; list it as
valid objects properly.
Co-authored-by: Krishnan Parthasarathi <Krishnan Parthasarathi>
2024-06-07 15:18:44 -07:00
2dd8faaedc
remove unnecessary log in Listing()
2024-06-07 14:52:55 -07:00
069c4015cd
Don't tier directory objects ( #19891 )
...
Directory objects are used by applications that simulate the folder
structure of an on-disk filesystem. These are zero-byte objects with names
ending with '/'. They are only used to check whether a 'folder' exists in
the namespace.
2024-06-07 08:43:17 -07:00
2f6e03fb60
Calculate correct object size while replication ( #19888 )
...
It was missing in case of `replicateObject` but was present for
`replicateAll` already
Signed-off-by: Shubhendu Ram Tripathi <shubhendu@minio.io >
2024-06-06 12:31:01 -07:00
0fbb945e13
Disable caching of encrypted objects ( #19890 )
...
Don't write encrypted objects to cache, if configured.
2024-06-06 11:39:18 -07:00
b94dd835c9
decom: Fix CurrentSize output when generating the status ( #19883 )
...
StartSize starts with the raw free space of all disks in the given pool,
however during the status, CurrentSize is not showing the current free
raw space, as expected at least by `mc admin decom status` since it was
written.
2024-06-06 07:30:43 -07:00
5aaef9790f
replication: pass checksum headers to replica ( #19834 )
2024-06-06 02:36:42 -07:00
7edc352d23
Add ILM metrics in metrics-v3 ( #19539 )
...
Signed-off-by: Bala.FA <bala@minio.io >
2024-06-06 02:36:25 -07:00
850a84b08a
simplify site replication multipart proxying ( #19885 )
2024-06-05 18:01:15 -07:00
4148754ce0
Check both given and normalized group DN on LDAP policy detach requests ( #19876 )
2024-06-05 15:42:40 -07:00
2107722829
upgrade go-oidc to fix GO-2024-2631 ( #19884 )
2024-06-05 15:00:34 -07:00
d326ba52e9
feat: support batchJob for windows ( #19877 )
2024-06-05 08:44:53 -07:00
91e1487de4
Add LDAP public key authentication to SFTP ( #19833 )
2024-06-05 00:51:13 -07:00
90a9f2dd70
fix: log diskerror when detect the disk space failed ( #19861 )
2024-06-04 09:42:03 -07:00
d5e48cfd65
fix: remove DriveOPTimeout for REST callers as they don't work properly ( #19873 )
...
Go's net/http is notoriously difficult to have a streaming
deadlines per READ/WRITE on the net.Conn if we add them they
interfere with the Go's internal requirements for a HTTP
connection.
Remove this support for now
fixes #19853
2024-06-04 08:12:57 -07:00
d274566463
race: Fix rare race detected by testing ( #19872 )
...
Below is the race warning:
```
WARNING: DATA RACE
Write at 0x00c02d3d27c0 by goroutine 1210:
github.com/minio/minio/cmd.(*healingTracker).bucketDone()
github.com/minio/minio/cmd/background-newdisks-heal-ops.go:273 +0x13a
github.com/minio/minio/cmd.(*erasureObjects).healErasureSet()
github.com/minio/minio/cmd/global-heal.go:525 +0x2158
github.com/minio/minio/cmd.healFreshDisk()
github.com/minio/minio/cmd/background-newdisks-heal-ops.go:450 +0x107e
github.com/minio/minio/cmd.monitorLocalDisksAndHeal.func1()
github.com/minio/minio/cmd/background-newdisks-heal-ops.go:528 +0x150
github.com/minio/minio/cmd.monitorLocalDisksAndHeal.gowrap2()
github.com/minio/minio/cmd/background-newdisks-heal-ops.go:538 +0x82
Previous read at 0x00c02d3d27c0 by goroutine 1446:
github.com/minio/minio/cmd.(*erasureObjects).healErasureSet.func5()
github.com/minio/minio/cmd/global-heal.go:232 +0xfd
```
2024-06-04 08:12:32 -07:00
21b6204692
Test proxying of DEL marker for bucket replication ( #19870 )
...
Make sure to avoid proxying for DEL markers
Signed-off-by: Shubhendu Ram Tripathi <shubhendu@minio.io >
2024-06-04 04:38:26 -07:00
d98faeb26a
Check if LDAP User has attached policy before creating Service Account ( #19843 )
...
Check if ldap user has policy before creating
2024-06-03 12:58:48 -07:00
0a63dc199c
Add trace sizes to more trace types ( #19864 )
...
Add trace sizes to
* ILM traces
* Replication traces
* Healing traces
* Decommission traces
* Rebalance traces
* (s)ftp traces
* http traces.
2024-06-03 08:45:54 -07:00
e72429c79c
Add sizes to traces ( #19851 )
...
added to storage and grid traces. Can provide more context for traces that aren't HTTP. Others may apply.
2024-05-31 22:17:37 -07:00
c5b3f5553f
Add per connection RPC metrics ( #19852 )
...
Provides individual and aggregate stats for each RPC connection.
Example:
```
"rpc": {
"collectedAt": "2024-05-31T14:33:29.1373103+02:00",
"connected": 30,
"disconnected": 0,
"outgoingStreams": 69,
"incomingStreams": 0,
"outgoingBytes": 174822796,
"incomingBytes": 175821566,
"outgoingMessages": 768595,
"incomingMessages": 768589,
"outQueue": 0,
"lastPongTime": "2024-05-31T12:33:28Z",
"byDestination": {
"http://127.0.0.1:9001 ": {
"collectedAt": "2024-05-31T14:33:29.1373103+02:00",
"connected": 5,
"disconnected": 0,
"outgoingStreams": 2,
"incomingStreams": 0,
"outgoingBytes": 38432543,
"incomingBytes": 66604052,
"outgoingMessages": 229496,
"incomingMessages": 229575,
"outQueue": 0,
"lastPongTime": "2024-05-31T12:33:27Z"
},
"http://127.0.0.1:9002 ": {
"collectedAt": "2024-05-31T14:33:29.1373103+02:00",
"connected": 5,
"disconnected": 0,
"outgoingStreams": 6,
"incomingStreams": 0,
"outgoingBytes": 38215680,
"incomingBytes": 66121283,
"outgoingMessages": 228525,
"incomingMessages": 228510,
"outQueue": 0,
"lastPongTime": "2024-05-31T12:33:27Z"
},
...
```
2024-05-31 22:16:24 -07:00
d3ae0aaad3
Add max buffering to SFTP ( #19848 )
...
Prevent OOM by adversarial use of SFTP upload by setting a 100MB max upload buffer.
2024-05-31 14:28:07 -07:00
1277ad69a6
heal: Remove .healing.bin when all ES drives are healing ( #19846 )
...
In the very rare case when all drives in a erasure set need to be healed,
remove .healing.bin from all drives, otherwise it will be stuck in a
loop
Also, fix a unit test that fails sometimes due to wrong test.
2024-05-31 07:48:50 -07:00
8f93e81afb
change service account embedded policy size limit ( #19840 )
...
Bonus: trim-off all the unnecessary spaces to allow
for real 2048 characters in policies for STS handlers
and re-use the code in all STS handlers.
2024-05-30 11:10:41 -07:00
4af31e654b
avoid pre-populating buffers for deployments < 32GiB memory ( #19839 )
2024-05-30 04:58:12 -07:00
aad50579ba
fix: wire up ILM sub-system properly for help ( #19836 )
2024-05-30 01:14:58 -07:00
38d059b0ae
fix: single node multi-drive must register local drives properly ( #19832 )
...
since #19688 there was a regression introduced during drive
lookups for single node multi-drive setups, drive replacement
would not work correctly without this PR.
2024-05-29 13:12:44 -07:00
bd4eeb4522
Fix flipped EcM, EcN in metadata header ( #19831 )
...
Since this is a tuple encoded field we can just flip the struct members.
2024-05-29 12:14:09 -07:00
03e3493288
fix: correct parse the tagging error for PostPolicyBucketHandler ( #19825 )
2024-05-29 11:50:46 -07:00
64baedf5a4
fix: hide prefixes for Hadoop properly ( #19821 )
2024-05-28 15:53:15 -07:00
f79a4ef4d0
policy: More defensive code validating svc:DurationSeconds ( #19820 )
...
This does not fix any current issue, but merging https://github.com/minio/madmin-go/pull/282
can lose the validation of the service account expiration time.
Add more defensive code for now. In the future, we should avoid doing
validation in another library.
2024-05-28 10:19:04 -07:00
2d53854b19
Restrict access keys for users and groups to not allow '=' or ',' ( #19749 )
...
* initial commit
* Add UTF check
---------
Co-authored-by: Harshavardhana <harsha@minio.io >
2024-05-28 10:14:16 -07:00
c904ef966e
feat: support tags for PostPolicy upload ( #19816 )
2024-05-27 21:44:00 -07:00
Harshavardhana