mirror of
https://github.com/pgsty/minio.git
synced 2026-09-07 19:16:09 +03:00
Feng Ruohang
40bee4b7ba
DeleteObject ignored the If-Match request header and always deleted the object (204). AWS S3 conditional deletes require that when If-Match is provided and does not match the object's current ETag, the delete is refused with 412 Precondition Failed and the object is left intact. The precondition is evaluated in erasureServerPools.DeleteObject, while the server-pool delete lock is held, before the delete-marker short-circuit and before any version is removed. It runs against the version that will actually be deleted: pinfo.ObjInfo for a normal delete, or the specifically addressed version (read under the held lock) for a version-scoped delete, since getPoolInfoExistingWithOpts strips VersionID. The check is a pure function (no ResponseWriter writes) and returns PreConditionFailed, which toAPIError maps to 412; CheckPrecondFn is cleared before lower layers run so the precondition is evaluated exactly once. Semantics: - If-Match mismatch on a live object -> 412, object preserved. - If-Match "*" requires a live object; a delete-marker-latest -> 412, and an explicitly addressed delete-marker version -> 412 (getObjectInfo returns the marker with MethodNotAllowed; the marker is the precondition target, not a 405). - SSE-C/SSE-KMS: compared against the public ETag derived without the customer key, so a satisfiable condition is never falsely rejected. - Explicit versionId -> evaluated against that version; a missing addressed version -> NoSuchVersion whether or not the key exists; a missing object (no versionId) -> NoSuchKey; no If-Match -> unchanged (including the unconditional version-scoped delete's error behavior). Scope: atomicity is guaranteed for a single erasure set (the default deployment). Multi-pool conditional-delete atomicity (concurrent writers across pools, cross-pool version selection) is tracked as a follow-up. Tests: pure-helper unit test (delete marker, "*", SSE-C without key); object-layer tests (unversioned match/mismatch/missing, versioned delete-marker-latest and addressed delete-marker version, explicit-version selection, missing version on present and absent keys, read-quorum loss); handler tests (412/204/wildcard/404) across both backends, with red/green demonstrated per guard. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01L7qJqWwy8oFA6aCXWRzXQe Signed-off-by: Feng Ruohang <rh@vonng.com>
65 lines
2.8 KiB
Go
65 lines
2.8 KiB
Go
// Copyright (c) 2015-2025 MinIO, Inc.
|
|
//
|
|
// This file is part of MinIO Object Storage stack
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package cmd
|
|
|
|
import (
|
|
"net/http"
|
|
"testing"
|
|
|
|
"github.com/minio/minio/internal/crypto"
|
|
)
|
|
|
|
// TestDeleteIfMatchPreconditionFailed exercises the pure If-Match evaluation for
|
|
// DeleteObject, including delete markers, the "*" wildcard, and SSE-C objects
|
|
// whose public ETag must be derived without the customer key.
|
|
func TestDeleteIfMatchPreconditionFailed(t *testing.T) {
|
|
const plainETag = "d41d8cd98f00b204e9800998ecf8427e" // 32-char MD5, returned as-is
|
|
|
|
// SSE-C object: the stored ETag is longer than 32 chars and its public form
|
|
// is the trailing 32 chars, derived by getDecryptedETag without any key.
|
|
ssecPublic := "11112222333344445555666677778888"
|
|
ssecStored := "abcdef0123456789abcdef0123456789" + ssecPublic // 64 chars
|
|
ssecMeta := map[string]string{crypto.MetaSealedKeySSEC: "test-sealed-key"}
|
|
|
|
testCases := []struct {
|
|
name string
|
|
ifMatch string
|
|
oi ObjectInfo
|
|
want bool // true => precondition failed (delete refused, 412)
|
|
}{
|
|
{"live matching etag", plainETag, ObjectInfo{ETag: plainETag}, false},
|
|
{"live matching quoted etag", `"` + plainETag + `"`, ObjectInfo{ETag: plainETag}, false},
|
|
{"live non-matching etag", "0badbeef0badbeef0badbeef0badbeef", ObjectInfo{ETag: plainETag}, true},
|
|
{"live wildcard", "*", ObjectInfo{ETag: plainETag}, false},
|
|
{"live wildcard padded", " * ", ObjectInfo{ETag: plainETag}, false},
|
|
{"delete marker concrete etag", plainETag, ObjectInfo{DeleteMarker: true}, true},
|
|
{"delete marker wildcard", "*", ObjectInfo{DeleteMarker: true}, true},
|
|
{"ssec matching public etag", ssecPublic, ObjectInfo{ETag: ssecStored, UserDefined: ssecMeta}, false},
|
|
{"ssec wildcard", "*", ObjectInfo{ETag: ssecStored, UserDefined: ssecMeta}, false},
|
|
{"ssec non-matching etag", "99998888777766665555444433332222", ObjectInfo{ETag: ssecStored, UserDefined: ssecMeta}, true},
|
|
}
|
|
|
|
for _, tc := range testCases {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
if got := deleteIfMatchPreconditionFailed(http.Header{}, tc.ifMatch, tc.oi); got != tc.want {
|
|
t.Errorf("deleteIfMatchPreconditionFailed(%q) = %v, want %v", tc.ifMatch, got, tc.want)
|
|
}
|
|
})
|
|
}
|
|
}
|