mirror of
https://github.com/pgsty/minio.git
synced 2026-08-09 07:43:29 +03:00
Feng Ruohang
6613c2a3cb
The test and verification scripts invoked ./minio and pulled their tooling from upstream infrastructure with no integrity check. Every `curl | tar` of a client or an old server binary was an unverified execution path in a script that regularly runs as a privileged user, and several fetched a floating "latest". Two installers replace all of it: - install-mcli.sh resolves a pinned pgsty/mc release, downloads the archive and its checksum manifest, requires exactly one valid manifest entry for the asset, verifies it, and installs. MCLI_BIN with a mandatory MCLI_SHA256 lets an offline or air-gapped run supply its own binary, still checksum-checked. - install-verified-fixture.sh takes source, expected SHA-256 and target, and refuses anything that does not match. Sources may be a URL or a local file. Every script that previously downloaded mc now calls install-mcli.sh. The three places that genuinely need an upstream artifact - the old MinIO server binary for the LDAP IAM upgrade-import test, the 2021 mc for the three-site replication test, and the functional-tests.sh fixture - go through install-verified-fixture.sh with the digest recorded inline. Those dl.min.io URLs remain on purpose: they are historical upstream artifacts needed to prove upgrade compatibility, and they are now pinned and verified rather than trusted. The scripts otherwise switch to ./silo, silo.service, the silo container and compose service names, and SILO_CONFIG_DIR. run-multi-site-minio-idp.sh is renamed to run-multi-site-silo-idp.sh with the Makefile target following. buildscripts/minio-upgrade.sh keeps its name and its `minio server` argv - it exists to test the MinIO-to-Silo upgrade, so the old side must stay old - but it is now pinned to an image digest rather than a tag, and its `docker system prune` and `docker volume prune` calls are removed. Those ran unfiltered against the developer's whole Docker installation; the resiliency tests had the same problem and lose their prune and `docker ps -q` sweeps too. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
152 lines
3.4 KiB
Bash
Executable File
152 lines
3.4 KiB
Bash
Executable File
#!/bin/bash -e
|
|
|
|
set -E
|
|
set -o pipefail
|
|
set -x
|
|
|
|
WORK_DIR="$PWD/.verify-$RANDOM"
|
|
SILO_CONFIG_DIR="$WORK_DIR/.silo"
|
|
MINIO_OLD=("$PWD/minio.RELEASE.2020-10-28T08-16-50Z" --config-dir "$SILO_CONFIG_DIR" server)
|
|
SILO=("$PWD/silo" --config-dir "$SILO_CONFIG_DIR" server)
|
|
|
|
if [ ! -x "$PWD/silo" ]; then
|
|
echo "Silo executable binary not found in current directory"
|
|
exit 1
|
|
fi
|
|
|
|
function download_old_release() {
|
|
if [ ! -x minio.RELEASE.2020-10-28T08-16-50Z ]; then
|
|
: "${SILO_LEGACY_FIXTURE_2020:?set SILO_LEGACY_FIXTURE_2020 to the audited legacy binary}"
|
|
: "${SILO_LEGACY_SHA256_2020:?set SILO_LEGACY_SHA256_2020 to its audited SHA-256}"
|
|
"$(git rev-parse --show-toplevel)/buildscripts/install-verified-fixture.sh" \
|
|
"${SILO_LEGACY_FIXTURE_2020}" "${SILO_LEGACY_SHA256_2020}" \
|
|
"minio.RELEASE.2020-10-28T08-16-50Z"
|
|
fi
|
|
}
|
|
|
|
function verify_rewrite() {
|
|
start_port=$1
|
|
|
|
export MINIO_ACCESS_KEY=silo
|
|
export MINIO_SECRET_KEY=silo123
|
|
export MC_HOST_silo="http://silo:silo123@127.0.0.1:${start_port}/"
|
|
unset MINIO_KMS_AUTO_ENCRYPTION # do not auto-encrypt objects
|
|
export MINIO_CI_CD=1
|
|
|
|
mkdir -p "${WORK_DIR}"
|
|
"$(git rev-parse --show-toplevel)/buildscripts/install-mcli.sh" "${WORK_DIR}/mc"
|
|
|
|
"${MINIO_OLD[@]}" --address ":$start_port" "${WORK_DIR}/xl{1...16}" >"${WORK_DIR}/server1.log" 2>&1 &
|
|
pid=$!
|
|
disown $pid
|
|
|
|
"${WORK_DIR}/mc" ready silo/
|
|
|
|
if ! ps -p ${pid} 1>&2 >/dev/null; then
|
|
echo "server1 log:"
|
|
cat "${WORK_DIR}/server1.log"
|
|
echo "FAILED"
|
|
purge "$WORK_DIR"
|
|
exit 1
|
|
fi
|
|
|
|
"${WORK_DIR}/mc" mb silo/healing-rewrite-bucket --quiet --with-lock
|
|
"${WORK_DIR}/mc" cp \
|
|
buildscripts/verify-build.sh \
|
|
silo/healing-rewrite-bucket/ \
|
|
--disable-multipart --quiet
|
|
|
|
"${WORK_DIR}/mc" cp \
|
|
buildscripts/verify-build.sh \
|
|
silo/healing-rewrite-bucket/ \
|
|
--disable-multipart --quiet
|
|
|
|
"${WORK_DIR}/mc" cp \
|
|
buildscripts/verify-build.sh \
|
|
silo/healing-rewrite-bucket/ \
|
|
--disable-multipart --quiet
|
|
|
|
kill ${pid}
|
|
sleep 3
|
|
|
|
"${SILO[@]}" --address ":$start_port" "${WORK_DIR}/xl{1...16}" >"${WORK_DIR}/server1.log" 2>&1 &
|
|
pid=$!
|
|
disown $pid
|
|
|
|
"${WORK_DIR}/mc" ready silo/
|
|
|
|
if ! ps -p ${pid} 1>&2 >/dev/null; then
|
|
echo "server1 log:"
|
|
cat "${WORK_DIR}/server1.log"
|
|
echo "FAILED"
|
|
purge "$WORK_DIR"
|
|
exit 1
|
|
fi
|
|
|
|
if ! ./s3-check-md5 \
|
|
-debug \
|
|
-versions \
|
|
-access-key silo \
|
|
-secret-key silo123 \
|
|
-endpoint "http://127.0.0.1:${start_port}/" 2>&1 | grep INTACT; then
|
|
echo "server1 log:"
|
|
cat "${WORK_DIR}/server1.log"
|
|
echo "FAILED"
|
|
mkdir -p inspects
|
|
(
|
|
cd inspects
|
|
"${WORK_DIR}/mc" admin inspect silo/healing-rewrite-bucket/verify-build.sh/**
|
|
)
|
|
|
|
"${WORK_DIR}/mc" mb play/inspects
|
|
"${WORK_DIR}/mc" mirror inspects play/inspects
|
|
|
|
purge "$WORK_DIR"
|
|
exit 1
|
|
fi
|
|
|
|
go run ./buildscripts/heal-manual.go "127.0.0.1:${start_port}" "silo" "silo123"
|
|
sleep 1
|
|
|
|
if ! ./s3-check-md5 \
|
|
-debug \
|
|
-versions \
|
|
-access-key silo \
|
|
-secret-key silo123 \
|
|
-endpoint http://127.0.0.1:${start_port}/ 2>&1 | grep INTACT; then
|
|
echo "server1 log:"
|
|
cat "${WORK_DIR}/server1.log"
|
|
echo "FAILED"
|
|
mkdir -p inspects
|
|
(
|
|
cd inspects
|
|
"${WORK_DIR}/mc" admin inspect silo/healing-rewrite-bucket/verify-build.sh/**
|
|
)
|
|
|
|
"${WORK_DIR}/mc" mb play/inspects
|
|
"${WORK_DIR}/mc" mirror inspects play/inspects
|
|
|
|
purge "$WORK_DIR"
|
|
exit 1
|
|
fi
|
|
|
|
kill ${pid}
|
|
}
|
|
|
|
function main() {
|
|
download_old_release
|
|
|
|
start_port=$(shuf -i 10000-65000 -n 1)
|
|
|
|
verify_rewrite ${start_port}
|
|
}
|
|
|
|
function purge() {
|
|
rm -rf "$1"
|
|
}
|
|
|
|
(main "$@")
|
|
rv=$?
|
|
purge "$WORK_DIR"
|
|
exit "$rv"
|