mirror of
https://github.com/pgsty/minio.git
synced 2026-08-10 00:03:29 +03:00
77bdc4c0cd
Two coupled changes that must land together, because the same files carry both: the server now identifies itself as Silo, and every path that would have called home to a MinIO-operated service is closed. Product identity - build-constants.go: store name, UA name and startup banner become Silo. The Go identifiers (MinioStoreName, MinioBannerName, ...) keep their names on purpose - renaming exported symbols would churn the compatibility surface for a cosmetic gain, and the rebrand guard freezes that surface. - main.go, server-startup-msg.go, ftp-server.go and the user-visible log, help and error strings across cmd/ and internal/ switch to Silo. Original MinIO copyright, LICENSE, NOTICE and CREDITS are untouched; --version now prints the upstream copyright, the pgsty modification notice, and the trademark policy's approved "based on MinIO technology" attribution. - api-headers.go: the HTTP Server header becomes "Silo". This is the one externally observable identity change, so TestCommonHeadersUseSiloProductName pins it - probes that sniff for "MinIO" must move to capability detection. - Prometheus metric HELP strings keep their MinIO wording. They are part of the metrics contract the guard protects, not product copy. Configuration directory - config-dir.go: new installs use ~/.silo. If only ~/.minio exists it is still read, with a one-time notice and no files moved. If both exist ~/.silo wins and an ambiguity warning is emitted; an explicit --config-dir always wins. Covered by TestSelectDefaultConfigDir. The internal .minio.sys layout is never renamed - this rule applies to the user config directory only. Upstream service lockdown - globalInplaceUpdateDisabled is now true at initialization rather than being set from MINIO_UPDATE. common-main.go still parses MINIO_UPDATE so upgrading nodes do not fail on an unknown key, but warns that the value is ignored; there is no way to re-enable the updater. TestInplaceUpdateCannotBeEnabled guards that. Without this, an admin with mc could have overwritten /usr/bin/silo with an upstream MinIO binary. - verifyBinary and commitBinary refuse early; the ServerUpdate v1/v2 admin routes and the peer-rest update endpoints stay registered and keep returning the existing programmatic error, so clients see a stable failure rather than a 404. - MinioReleaseBaseURL and defaultMinisignPubkey are emptied: no dl.min.io download root, and upstream's minisign key is no longer a trust root for anything this fork ships. - cmd/callhome.go is deleted and internal/config/subnet/ is reduced to parsing its old keys and reporting that the integration is disabled. config-current.go warns instead of failing when callhome or SUBNET settings are present, so an upgraded node with those keys still starts. - internal/config/errors.go replaces the MinIO Slack and support entry points with Silo documentation and issue links. Error codes and programmatic fields are unchanged. Verified: the compatibility baseline is unchanged except for the deliberate removal of the /api/health/upload SUBNET route; go build, go vet and the full cmd/ and internal/ unit suites pass; a locally built binary starts, serves S3/Admin/metrics on the unchanged /minio/* routes, answers with Server: Silo, and falls back to a pre-existing ~/.minio with the expected notice. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
240 lines
5.8 KiB
Go
240 lines
5.8 KiB
Go
// Copyright (c) 2015-2024 MinIO, Inc.
|
|
//
|
|
// This file is part of MinIO Object Storage stack
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package logger
|
|
|
|
import (
|
|
"encoding/json"
|
|
"fmt"
|
|
"io"
|
|
"os"
|
|
"path/filepath"
|
|
"time"
|
|
|
|
"github.com/klauspost/compress/gzip"
|
|
"github.com/minio/madmin-go/v3/logger/log"
|
|
xioutil "github.com/minio/minio/internal/ioutil"
|
|
)
|
|
|
|
func defaultFilenameFunc() string {
|
|
return fmt.Sprintf("silo-%s.log", fmt.Sprintf("%X", time.Now().UTC().UnixNano()))
|
|
}
|
|
|
|
// Options define configuration options for Writer
|
|
type Options struct {
|
|
// Directory defines the directory where log files will be written to.
|
|
// If the directory does not exist, it will be created.
|
|
Directory string
|
|
|
|
// MaximumFileSize defines the maximum size of each log file in bytes.
|
|
MaximumFileSize int64
|
|
|
|
// FileNameFunc specifies the name a new file will take.
|
|
// FileNameFunc must ensure collisions in filenames do not occur.
|
|
// Do not rely on timestamps to be unique, high throughput writes
|
|
// may fall on the same timestamp.
|
|
// Eg.
|
|
// 2020-03-28_15-00-945-<random-hash>.log
|
|
// When FileNameFunc is not specified, DefaultFilenameFunc will be used.
|
|
FileNameFunc func() string
|
|
|
|
// Compress specify if you want the logs to be compressed after rotation.
|
|
Compress bool
|
|
}
|
|
|
|
// Writer is a concurrency-safe writer with file rotation.
|
|
type Writer struct {
|
|
// opts are the configuration options for this Writer
|
|
opts Options
|
|
|
|
// f is the currently open file used for appends.
|
|
// Writes to f are only synchronized once Close() is called,
|
|
// or when files are being rotated.
|
|
f *os.File
|
|
|
|
pw *xioutil.PipeWriter
|
|
pr *xioutil.PipeReader
|
|
}
|
|
|
|
// Write writes p into the current file, rotating if necessary.
|
|
// Write is non-blocking, if the writer's queue is not full.
|
|
// Write is blocking otherwise.
|
|
func (w *Writer) Write(p []byte) (n int, err error) {
|
|
return w.pw.Write(p)
|
|
}
|
|
|
|
// Close closes the writer.
|
|
// Any accepted writes will be flushed. Any new writes will be rejected.
|
|
// Once Close() exits, files are synchronized to disk.
|
|
func (w *Writer) Close() error {
|
|
w.pw.CloseWithError(nil)
|
|
|
|
if w.f != nil {
|
|
if err := w.closeCurrentFile(); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
var stdErrEnc = json.NewEncoder(os.Stderr)
|
|
|
|
func (w *Writer) listen() {
|
|
for {
|
|
var r io.Reader = w.pr
|
|
if w.opts.MaximumFileSize > 0 {
|
|
r = io.LimitReader(w.pr, w.opts.MaximumFileSize)
|
|
}
|
|
if _, err := io.Copy(w.f, r); err != nil {
|
|
msg := fmt.Sprintf("unable to write to log file %v: %v", w.f.Name(), err)
|
|
stdErrEnc.Encode(&log.Entry{
|
|
Level: ErrorKind,
|
|
Message: msg,
|
|
Time: time.Now().UTC(),
|
|
Trace: &log.Trace{Message: msg},
|
|
})
|
|
}
|
|
if err := w.rotate(); err != nil {
|
|
msg := fmt.Sprintf("unable to rotate log file %v: %v", w.f.Name(), err)
|
|
stdErrEnc.Encode(&log.Entry{
|
|
Level: ErrorKind,
|
|
Message: msg,
|
|
Time: time.Now().UTC(),
|
|
Trace: &log.Trace{Message: msg},
|
|
})
|
|
}
|
|
}
|
|
}
|
|
|
|
func (w *Writer) closeCurrentFile() error {
|
|
if err := w.f.Close(); err != nil {
|
|
return fmt.Errorf("unable to close current log file: %w", err)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (w *Writer) compress() error {
|
|
if !w.opts.Compress {
|
|
return nil
|
|
}
|
|
|
|
oldLgFile := w.f.Name()
|
|
r, err := os.Open(oldLgFile)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
defer r.Close()
|
|
|
|
gw, err := os.Create(oldLgFile + ".gz")
|
|
if err != nil {
|
|
return err
|
|
}
|
|
defer gw.Close()
|
|
|
|
var wc io.WriteCloser = gzip.NewWriter(gw)
|
|
if _, err = io.Copy(wc, r); err != nil {
|
|
return err
|
|
}
|
|
|
|
if err = wc.Close(); err != nil {
|
|
return err
|
|
}
|
|
|
|
// Persist to disk any caches.
|
|
if err = gw.Sync(); err != nil {
|
|
return err
|
|
}
|
|
|
|
// close everything before we delete.
|
|
if err = gw.Close(); err != nil {
|
|
return err
|
|
}
|
|
|
|
if err = r.Close(); err != nil {
|
|
return err
|
|
}
|
|
|
|
// Attempt to remove after all fd's are closed.
|
|
return os.Remove(oldLgFile)
|
|
}
|
|
|
|
func (w *Writer) rotate() error {
|
|
if w.f != nil {
|
|
if err := w.closeCurrentFile(); err != nil {
|
|
return err
|
|
}
|
|
|
|
// This function is a no-op if opts.Compress is false
|
|
// writes an error in JSON form to stderr, if we cannot
|
|
// compress.
|
|
if err := w.compress(); err != nil {
|
|
msg := fmt.Sprintf("unable to compress log file %v: %v, ignoring and moving on", w.f.Name(), err)
|
|
stdErrEnc.Encode(&log.Entry{
|
|
Level: ErrorKind,
|
|
Message: msg,
|
|
Time: time.Now().UTC(),
|
|
Trace: &log.Trace{Message: msg},
|
|
})
|
|
}
|
|
}
|
|
|
|
path := filepath.Join(w.opts.Directory, w.opts.FileNameFunc())
|
|
f, err := newFile(path)
|
|
if err != nil {
|
|
return fmt.Errorf("unable to create new file at %v: %w", path, err)
|
|
}
|
|
|
|
w.f = f
|
|
|
|
return nil
|
|
}
|
|
|
|
// NewDir creates a new concurrency safe Writer which performs log rotation.
|
|
func NewDir(opts Options) (io.WriteCloser, error) {
|
|
if err := os.MkdirAll(opts.Directory, os.ModePerm); err != nil {
|
|
return nil, fmt.Errorf("directory %v does not exist and could not be created: %w", opts.Directory, err)
|
|
}
|
|
|
|
if opts.FileNameFunc == nil {
|
|
opts.FileNameFunc = defaultFilenameFunc
|
|
}
|
|
|
|
pr, pw := xioutil.WaitPipe()
|
|
|
|
w := &Writer{
|
|
opts: opts,
|
|
pw: pw,
|
|
pr: pr,
|
|
}
|
|
|
|
if w.f == nil {
|
|
if err := w.rotate(); err != nil {
|
|
return nil, fmt.Errorf("Failed to create log file: %w", err)
|
|
}
|
|
}
|
|
|
|
go w.listen()
|
|
|
|
return w, nil
|
|
}
|
|
|
|
func newFile(path string) (*os.File, error) {
|
|
return os.OpenFile(path, os.O_WRONLY|os.O_TRUNC|os.O_CREATE|os.O_SYNC, 0o666)
|
|
}
|