mirror of
https://github.com/pgsty/minio.git
synced 2026-08-10 00:03:29 +03:00
77bdc4c0cd
Two coupled changes that must land together, because the same files carry both: the server now identifies itself as Silo, and every path that would have called home to a MinIO-operated service is closed. Product identity - build-constants.go: store name, UA name and startup banner become Silo. The Go identifiers (MinioStoreName, MinioBannerName, ...) keep their names on purpose - renaming exported symbols would churn the compatibility surface for a cosmetic gain, and the rebrand guard freezes that surface. - main.go, server-startup-msg.go, ftp-server.go and the user-visible log, help and error strings across cmd/ and internal/ switch to Silo. Original MinIO copyright, LICENSE, NOTICE and CREDITS are untouched; --version now prints the upstream copyright, the pgsty modification notice, and the trademark policy's approved "based on MinIO technology" attribution. - api-headers.go: the HTTP Server header becomes "Silo". This is the one externally observable identity change, so TestCommonHeadersUseSiloProductName pins it - probes that sniff for "MinIO" must move to capability detection. - Prometheus metric HELP strings keep their MinIO wording. They are part of the metrics contract the guard protects, not product copy. Configuration directory - config-dir.go: new installs use ~/.silo. If only ~/.minio exists it is still read, with a one-time notice and no files moved. If both exist ~/.silo wins and an ambiguity warning is emitted; an explicit --config-dir always wins. Covered by TestSelectDefaultConfigDir. The internal .minio.sys layout is never renamed - this rule applies to the user config directory only. Upstream service lockdown - globalInplaceUpdateDisabled is now true at initialization rather than being set from MINIO_UPDATE. common-main.go still parses MINIO_UPDATE so upgrading nodes do not fail on an unknown key, but warns that the value is ignored; there is no way to re-enable the updater. TestInplaceUpdateCannotBeEnabled guards that. Without this, an admin with mc could have overwritten /usr/bin/silo with an upstream MinIO binary. - verifyBinary and commitBinary refuse early; the ServerUpdate v1/v2 admin routes and the peer-rest update endpoints stay registered and keep returning the existing programmatic error, so clients see a stable failure rather than a 404. - MinioReleaseBaseURL and defaultMinisignPubkey are emptied: no dl.min.io download root, and upstream's minisign key is no longer a trust root for anything this fork ships. - cmd/callhome.go is deleted and internal/config/subnet/ is reduced to parsing its old keys and reporting that the integration is disabled. config-current.go warns instead of failing when callhome or SUBNET settings are present, so an upgraded node with those keys still starts. - internal/config/errors.go replaces the MinIO Slack and support entry points with Silo documentation and issue links. Error codes and programmatic fields are unchanged. Verified: the compatibility baseline is unchanged except for the deliberate removal of the /api/health/upload SUBNET route; go build, go vet and the full cmd/ and internal/ unit suites pass; a locally built binary starts, serves S3/Admin/metrics on the unchanged /minio/* routes, answers with Server: Silo, and falls back to a pre-existing ~/.minio with the expected notice. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
172 lines
5.2 KiB
Go
172 lines
5.2 KiB
Go
// Copyright (c) 2015-2023 MinIO, Inc.
|
|
//
|
|
// This file is part of MinIO Object Storage stack
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package cmd
|
|
|
|
import (
|
|
"fmt"
|
|
"net"
|
|
"strconv"
|
|
"strings"
|
|
|
|
"github.com/minio/minio/internal/logger"
|
|
ftp "goftp.io/server/v2"
|
|
)
|
|
|
|
var globalRemoteFTPClientTransport = NewRemoteTargetHTTPTransport(true)()
|
|
|
|
// minioLogger use an instance of this to log in a standard format
|
|
type minioLogger struct{}
|
|
|
|
// Print implement Logger
|
|
func (log *minioLogger) Print(sessionID string, message any) {
|
|
if serverDebugLog {
|
|
fmt.Printf("%s %s\n", sessionID, message)
|
|
}
|
|
}
|
|
|
|
// Printf implement Logger
|
|
func (log *minioLogger) Printf(sessionID string, format string, v ...any) {
|
|
if serverDebugLog {
|
|
if sessionID != "" {
|
|
fmt.Printf("%s %s\n", sessionID, fmt.Sprintf(format, v...))
|
|
} else {
|
|
fmt.Printf(format+"\n", v...)
|
|
}
|
|
}
|
|
}
|
|
|
|
// PrintCommand implement Logger
|
|
func (log *minioLogger) PrintCommand(sessionID string, command string, params string) {
|
|
if serverDebugLog {
|
|
if command == "PASS" {
|
|
fmt.Printf("%s > PASS ****\n", sessionID)
|
|
} else {
|
|
fmt.Printf("%s > %s %s\n", sessionID, command, params)
|
|
}
|
|
}
|
|
}
|
|
|
|
// PrintResponse implement Logger
|
|
func (log *minioLogger) PrintResponse(sessionID string, code int, message string) {
|
|
if serverDebugLog {
|
|
fmt.Printf("%s < %d %s\n", sessionID, code, message)
|
|
}
|
|
}
|
|
|
|
func startFTPServer(args []string) {
|
|
var (
|
|
port int
|
|
publicIP string
|
|
portRange string
|
|
tlsPrivateKey string
|
|
tlsPublicCert string
|
|
forceTLS bool
|
|
)
|
|
|
|
var err error
|
|
for _, arg := range args {
|
|
tokens := strings.SplitN(arg, "=", 2)
|
|
if len(tokens) != 2 {
|
|
logger.Fatal(fmt.Errorf("invalid arguments passed to --ftp=%s", arg), "unable to start FTP server")
|
|
}
|
|
switch tokens[0] {
|
|
case "address":
|
|
host, portStr, err := net.SplitHostPort(tokens[1])
|
|
if err != nil {
|
|
logger.Fatal(fmt.Errorf("invalid arguments passed to --ftp=%s (%v)", arg, err), "unable to start FTP server")
|
|
}
|
|
port, err = strconv.Atoi(portStr)
|
|
if err != nil {
|
|
logger.Fatal(fmt.Errorf("invalid arguments passed to --ftp=%s (%v)", arg, err), "unable to start FTP server")
|
|
}
|
|
if port < 1 || port > 65535 {
|
|
logger.Fatal(fmt.Errorf("invalid arguments passed to --ftp=%s, (port number must be between 1 to 65535)", arg), "unable to start FTP server")
|
|
}
|
|
publicIP = host
|
|
case "passive-port-range":
|
|
portRange = tokens[1]
|
|
case "tls-private-key":
|
|
tlsPrivateKey = tokens[1]
|
|
case "tls-public-cert":
|
|
tlsPublicCert = tokens[1]
|
|
case "force-tls":
|
|
forceTLS, err = strconv.ParseBool(tokens[1])
|
|
if err != nil {
|
|
logger.Fatal(fmt.Errorf("invalid arguments passed to --ftp=%s (%v)", arg, err), "unable to start FTP server")
|
|
}
|
|
}
|
|
}
|
|
|
|
// Verify if only partial inputs are given for FTP(secure)
|
|
{
|
|
if tlsPrivateKey == "" && tlsPublicCert != "" {
|
|
logger.Fatal(fmt.Errorf("invalid TLS arguments provided missing private key --ftp=\"tls-private-key=path/to/private.key\""), "unable to start FTP server")
|
|
}
|
|
|
|
if tlsPrivateKey != "" && tlsPublicCert == "" {
|
|
logger.Fatal(fmt.Errorf("invalid TLS arguments provided missing public cert --ftp=\"tls-public-cert=path/to/public.crt\""), "unable to start FTP server")
|
|
}
|
|
if port == 0 {
|
|
port = 8021 // Default FTP port, since no port was given.
|
|
}
|
|
}
|
|
|
|
// If no TLS certs were provided, server is running in TLS for S3 API
|
|
// we automatically make FTP also run under TLS mode.
|
|
if globalIsTLS && tlsPrivateKey == "" && tlsPublicCert == "" {
|
|
tlsPrivateKey = getPrivateKeyFile()
|
|
tlsPublicCert = getPublicCertFile()
|
|
}
|
|
|
|
tls := tlsPrivateKey != "" && tlsPublicCert != ""
|
|
|
|
if forceTLS && !tls {
|
|
logger.Fatal(fmt.Errorf("invalid TLS arguments provided. force-tls, but missing private key --ftp=\"tls-private-key=path/to/private.key\""), "unable to start FTP server")
|
|
}
|
|
|
|
name := "Silo FTP Server"
|
|
if tls {
|
|
name = "Silo FTP(Secure) Server"
|
|
}
|
|
|
|
ftpServer, err := ftp.NewServer(&ftp.Options{
|
|
Name: name,
|
|
WelcomeMessage: fmt.Sprintf("Welcome to '%s' FTP Server Version='%s' License='%s'", MinioStoreName, MinioLicense, Version),
|
|
Driver: NewFTPDriver(),
|
|
Port: port,
|
|
Perm: ftp.NewSimplePerm("nobody", "nobody"),
|
|
TLS: tls,
|
|
KeyFile: tlsPrivateKey,
|
|
CertFile: tlsPublicCert,
|
|
ExplicitFTPS: tls,
|
|
Logger: &minioLogger{},
|
|
PassivePorts: portRange,
|
|
PublicIP: publicIP,
|
|
ForceTLS: forceTLS,
|
|
})
|
|
if err != nil {
|
|
logger.Fatal(err, "unable to initialize FTP server")
|
|
}
|
|
|
|
logger.Info(fmt.Sprintf("%s listening on %s", name, net.JoinHostPort(publicIP, strconv.Itoa(port))))
|
|
|
|
if err = ftpServer.ListenAndServe(); err != nil {
|
|
logger.Fatal(err, "unable to start FTP server")
|
|
}
|
|
}
|