mirror of
https://github.com/pgsty/minio.git
synced 2026-08-10 00:03:29 +03:00
Feng Ruohang
6613c2a3cb
The test and verification scripts invoked ./minio and pulled their tooling from upstream infrastructure with no integrity check. Every `curl | tar` of a client or an old server binary was an unverified execution path in a script that regularly runs as a privileged user, and several fetched a floating "latest". Two installers replace all of it: - install-mcli.sh resolves a pinned pgsty/mc release, downloads the archive and its checksum manifest, requires exactly one valid manifest entry for the asset, verifies it, and installs. MCLI_BIN with a mandatory MCLI_SHA256 lets an offline or air-gapped run supply its own binary, still checksum-checked. - install-verified-fixture.sh takes source, expected SHA-256 and target, and refuses anything that does not match. Sources may be a URL or a local file. Every script that previously downloaded mc now calls install-mcli.sh. The three places that genuinely need an upstream artifact - the old MinIO server binary for the LDAP IAM upgrade-import test, the 2021 mc for the three-site replication test, and the functional-tests.sh fixture - go through install-verified-fixture.sh with the digest recorded inline. Those dl.min.io URLs remain on purpose: they are historical upstream artifacts needed to prove upgrade compatibility, and they are now pinned and verified rather than trusted. The scripts otherwise switch to ./silo, silo.service, the silo container and compose service names, and SILO_CONFIG_DIR. run-multi-site-minio-idp.sh is renamed to run-multi-site-silo-idp.sh with the Makefile target following. buildscripts/minio-upgrade.sh keeps its name and its `minio server` argv - it exists to test the MinIO-to-Silo upgrade, so the old side must stay old - but it is now pinned to an image digest rather than a tag, and its `docker system prune` and `docker volume prune` calls are removed. Those ran unfiltered against the developer's whole Docker installation; the resiliency tests had the same problem and lose their prune and `docker ps -q` sweeps too. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
97 lines
2.2 KiB
Bash
Executable File
97 lines
2.2 KiB
Bash
Executable File
#!/bin/bash -e
|
|
|
|
set -E
|
|
set -o pipefail
|
|
set -x
|
|
|
|
if [ ! -x "$PWD/silo" ]; then
|
|
echo "Silo executable binary not found in current directory"
|
|
exit 1
|
|
fi
|
|
|
|
WORK_DIR="$(mktemp -d)"
|
|
SILO_CONFIG_DIR="$WORK_DIR/.silo"
|
|
SILO=("$PWD/silo" --config-dir "$SILO_CONFIG_DIR" server)
|
|
|
|
function start_silo() {
|
|
start_port=$1
|
|
|
|
export MINIO_ROOT_USER=silo
|
|
export MINIO_ROOT_PASSWORD=silo123
|
|
unset MINIO_KMS_AUTO_ENCRYPTION # do not auto-encrypt objects
|
|
unset MINIO_CI_CD
|
|
unset CI
|
|
|
|
args=()
|
|
for i in $(seq 1 4); do
|
|
args+=("http://localhost:$((start_port + i))${WORK_DIR}/mnt/disk$i/ ")
|
|
done
|
|
|
|
for i in $(seq 1 4); do
|
|
"${SILO[@]}" --address ":$((start_port + i))" ${args[@]} 2>&1 >"${WORK_DIR}/server$i.log" &
|
|
done
|
|
|
|
# Wait until all nodes return 403
|
|
for i in $(seq 1 4); do
|
|
while [ "$(curl -m 1 -s -o /dev/null -w "%{http_code}" http://localhost:$((start_port + i)))" -ne "403" ]; do
|
|
echo -n "."
|
|
sleep 1
|
|
done
|
|
done
|
|
|
|
}
|
|
|
|
# Prepare fake disks with losetup
|
|
function prepare_block_devices() {
|
|
set -e
|
|
mkdir -p ${WORK_DIR}/disks/ ${WORK_DIR}/mnt/
|
|
sudo modprobe loop
|
|
for i in 1 2 3 4; do
|
|
dd if=/dev/zero of=${WORK_DIR}/disks/img.${i} bs=1M count=2000
|
|
device=$(sudo losetup --find --show ${WORK_DIR}/disks/img.${i})
|
|
sudo mkfs.ext4 -F ${device}
|
|
mkdir -p ${WORK_DIR}/mnt/disk${i}/
|
|
sudo mount ${device} ${WORK_DIR}/mnt/disk${i}/
|
|
sudo chown "$(id -u):$(id -g)" ${device} ${WORK_DIR}/mnt/disk${i}/
|
|
done
|
|
set +e
|
|
}
|
|
|
|
# Start a distributed MinIO setup, unmount one disk and check if it is formatted
|
|
function main() {
|
|
start_port=$(shuf -i 10000-65000 -n 1)
|
|
start_silo ${start_port}
|
|
|
|
# Unmount the disk, after the unmount the device id
|
|
# /tmp/xxx/mnt/disk4 will be the same as '/' and it
|
|
# will be detected as root disk
|
|
while [ "$u" != "0" ]; do
|
|
sudo umount ${WORK_DIR}/mnt/disk4/
|
|
u=$?
|
|
sleep 1
|
|
done
|
|
|
|
# Wait until MinIO self heal kicks in
|
|
sleep 60
|
|
|
|
if [ -f ${WORK_DIR}/mnt/disk4/.minio.sys/format.json ]; then
|
|
echo "A root disk is formatted unexpectedely"
|
|
cat "${WORK_DIR}/server4.log"
|
|
exit -1
|
|
fi
|
|
}
|
|
|
|
function cleanup() {
|
|
pkill silo
|
|
sudo umount ${WORK_DIR}/mnt/disk{1..3}/
|
|
sudo rm /dev/minio-loopdisk*
|
|
rm -rf "$WORK_DIR"
|
|
}
|
|
|
|
(prepare_block_devices)
|
|
(main "$@")
|
|
rv=$?
|
|
|
|
cleanup
|
|
exit "$rv"
|