mirror of
https://github.com/pgsty/minio.git
synced 2026-10-17 15:16:00 +03:00
Feng Ruohang
e90cb2067d
Continue PR #221 while retaining its original commits and authorship. Route latest-only fallback reads through the namespace lock used by normal writes, propagate terminal scan errors before cache completion, and retain delete markers until the cross-pool merge has resolved them. Recount narrowly eligible latest null-version metadata when mixed erasure layouts prevent selection. Keep each EC group separate and preserve the requested quorum, strict resolution, and version-listing behavior. Add regression coverage for locking, terminal errors, cache completion, delete markers, mixed EC layouts, and HTTP behavior; run focused race tests in CI. Verified with make test, focused race tests, and local distributed single- and multi-pool rolling-restart workloads with exact final oracles. Refs: https://github.com/pgsty/silo/issues/218 Refs: https://github.com/pgsty/silo/pull/221 Signed-off-by: Feng Ruohang <rh@vonng.com>
85 lines
2.9 KiB
Go
85 lines
2.9 KiB
Go
// Copyright (c) 2026 Feng Ruohang
|
|
//
|
|
// This file is part of Silo Object Storage stack
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package cmd
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/minio/minio/internal/dsync"
|
|
)
|
|
|
|
// Use the real distributed-lock algorithm with in-process lock servers.
|
|
// This is a protocol-level check, not a network or rolling-restart test.
|
|
func TestListFallbackDistributedLockRoute(t *testing.T) {
|
|
for _, tc := range []struct {
|
|
name string
|
|
multiPool, sharedLockers bool
|
|
}{
|
|
{"multi-pool-shared-lockers", true, true},
|
|
{"multi-pool-disjoint-lockers", true, false},
|
|
{"single-pool-target-set-lockers", false, false},
|
|
} {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
a := []dsync.NetLocker{newLocker(), newLocker()}
|
|
b := []dsync.NetLocker{newLocker(), newLocker()}
|
|
if tc.sharedLockers {
|
|
b = a
|
|
}
|
|
set0 := &erasureObjects{nsMutex: newNSLock(true), getLockers: func() ([]dsync.NetLocker, string) { return a, "listing-test" }}
|
|
target := &erasureObjects{nsMutex: newNSLock(true), getLockers: func() ([]dsync.NetLocker, string) { return b, "listing-test" }}
|
|
z := &erasureServerPools{serverPools: []*erasureSets{{sets: []*erasureObjects{set0, target}}}}
|
|
if tc.multiPool {
|
|
z.serverPools = []*erasureSets{{sets: []*erasureObjects{set0}}, {sets: []*erasureObjects{target}}}
|
|
}
|
|
writer := target.NewNSLock("bucket", "object")
|
|
if tc.multiPool {
|
|
writer = z.NewNSLock("bucket", "object")
|
|
}
|
|
wctx, err := writer.GetLock(t.Context(), globalOperationTimeout)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
locked := true
|
|
defer func() {
|
|
if locked {
|
|
writer.Unlock(wctx)
|
|
}
|
|
}()
|
|
reader := z.listingNSLock(target)("bucket", "object")
|
|
ctx, cancel := context.WithTimeout(t.Context(), 80*time.Millisecond)
|
|
defer cancel()
|
|
rctx, err := reader.GetRLock(ctx, globalOperationTimeout)
|
|
if err == nil {
|
|
reader.RUnlock(rctx)
|
|
t.Fatal("fallback read lock acquired while ordinary writer lock is held")
|
|
}
|
|
writer.Unlock(wctx)
|
|
locked = false
|
|
ctx, cancel = context.WithTimeout(t.Context(), 5*time.Second)
|
|
defer cancel()
|
|
rctx, err = reader.GetRLock(ctx, globalOperationTimeout)
|
|
if err != nil {
|
|
t.Fatalf("fallback read lock failed after writer unlock: %v", err)
|
|
}
|
|
reader.RUnlock(rctx)
|
|
})
|
|
}
|
|
}
|