mirror of
https://github.com/pgsty/minio.git
synced 2026-08-09 07:43:29 +03:00
77bdc4c0cd
Two coupled changes that must land together, because the same files carry both: the server now identifies itself as Silo, and every path that would have called home to a MinIO-operated service is closed. Product identity - build-constants.go: store name, UA name and startup banner become Silo. The Go identifiers (MinioStoreName, MinioBannerName, ...) keep their names on purpose - renaming exported symbols would churn the compatibility surface for a cosmetic gain, and the rebrand guard freezes that surface. - main.go, server-startup-msg.go, ftp-server.go and the user-visible log, help and error strings across cmd/ and internal/ switch to Silo. Original MinIO copyright, LICENSE, NOTICE and CREDITS are untouched; --version now prints the upstream copyright, the pgsty modification notice, and the trademark policy's approved "based on MinIO technology" attribution. - api-headers.go: the HTTP Server header becomes "Silo". This is the one externally observable identity change, so TestCommonHeadersUseSiloProductName pins it - probes that sniff for "MinIO" must move to capability detection. - Prometheus metric HELP strings keep their MinIO wording. They are part of the metrics contract the guard protects, not product copy. Configuration directory - config-dir.go: new installs use ~/.silo. If only ~/.minio exists it is still read, with a one-time notice and no files moved. If both exist ~/.silo wins and an ambiguity warning is emitted; an explicit --config-dir always wins. Covered by TestSelectDefaultConfigDir. The internal .minio.sys layout is never renamed - this rule applies to the user config directory only. Upstream service lockdown - globalInplaceUpdateDisabled is now true at initialization rather than being set from MINIO_UPDATE. common-main.go still parses MINIO_UPDATE so upgrading nodes do not fail on an unknown key, but warns that the value is ignored; there is no way to re-enable the updater. TestInplaceUpdateCannotBeEnabled guards that. Without this, an admin with mc could have overwritten /usr/bin/silo with an upstream MinIO binary. - verifyBinary and commitBinary refuse early; the ServerUpdate v1/v2 admin routes and the peer-rest update endpoints stay registered and keep returning the existing programmatic error, so clients see a stable failure rather than a 404. - MinioReleaseBaseURL and defaultMinisignPubkey are emptied: no dl.min.io download root, and upstream's minisign key is no longer a trust root for anything this fork ships. - cmd/callhome.go is deleted and internal/config/subnet/ is reduced to parsing its old keys and reporting that the integration is disabled. config-current.go warns instead of failing when callhome or SUBNET settings are present, so an upgraded node with those keys still starts. - internal/config/errors.go replaces the MinIO Slack and support entry points with Silo documentation and issue links. Error codes and programmatic fields are unchanged. Verified: the compatibility baseline is unchanged except for the deliberate removal of the /api/health/upload SUBNET route; go build, go vet and the full cmd/ and internal/ unit suites pass; a locally built binary starts, serves S3/Admin/metrics on the unchanged /minio/* routes, answers with Server: Silo, and falls back to a pre-existing ~/.minio with the expected notice. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
94 lines
4.1 KiB
Go
94 lines
4.1 KiB
Go
// Copyright (c) 2015-2021 MinIO, Inc.
|
|
//
|
|
// This file is part of MinIO Object Storage stack
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package cmd
|
|
|
|
import (
|
|
"fmt"
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/minio/minio/internal/color"
|
|
)
|
|
|
|
// Tests update notifier string builder.
|
|
func TestPrepareUpdateMessage(t *testing.T) {
|
|
testCases := []struct {
|
|
older time.Duration
|
|
dlURL string
|
|
|
|
expectedSubStr string
|
|
}{
|
|
// Testcase index 0
|
|
{72 * time.Hour, "my_download_url", "3 days before the latest release"},
|
|
{3 * time.Hour, "https://my_download_url_is_huge/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa", "3 hours before the latest release"},
|
|
{-72 * time.Hour, "another_update_url", ""},
|
|
{0, "another_update_url", ""},
|
|
{time.Hour, "", ""},
|
|
{0 * time.Second, "my_download_url", "now"},
|
|
{1 * time.Second, "my_download_url", "1 second before the latest release"},
|
|
{37 * time.Second, "my_download_url", "37 seconds before the latest release"},
|
|
{60 * time.Second, "my_download_url", "1 minute before the latest release"},
|
|
{61 * time.Second, "my_download_url", "1 minute before the latest release"},
|
|
|
|
// Testcase index 10
|
|
{37 * time.Minute, "my_download_url", "37 minutes before the latest release"},
|
|
{1 * time.Hour, "my_download_url", "1 hour before the latest release"},
|
|
{61 * time.Minute, "my_download_url", "1 hour before the latest release"},
|
|
{122 * time.Minute, "my_download_url", "2 hours before the latest release"},
|
|
{24 * time.Hour, "my_download_url", "1 day before the latest release"},
|
|
{25 * time.Hour, "my_download_url", "1 day before the latest release"},
|
|
{49 * time.Hour, "my_download_url", "2 days before the latest release"},
|
|
{7 * 24 * time.Hour, "my_download_url", "1 week before the latest release"},
|
|
{8 * 24 * time.Hour, "my_download_url", "1 week before the latest release"},
|
|
{15 * 24 * time.Hour, "my_download_url", "2 weeks before the latest release"},
|
|
|
|
// Testcase index 20
|
|
{30 * 24 * time.Hour, "my_download_url", "1 month before the latest release"},
|
|
{31 * 24 * time.Hour, "my_download_url", "1 month before the latest release"},
|
|
{61 * 24 * time.Hour, "my_download_url", "2 months before the latest release"},
|
|
{360 * 24 * time.Hour, "my_download_url", "1 year before the latest release"},
|
|
{361 * 24 * time.Hour, "my_download_url", "1 year before the latest release"},
|
|
{2 * 365 * 24 * time.Hour, "my_download_url", "2 years before the latest release"},
|
|
}
|
|
|
|
plainMsg := "You are running an older version of Silo released"
|
|
|
|
for i, testCase := range testCases {
|
|
output := prepareUpdateMessage(testCase.dlURL, testCase.older)
|
|
line1 := fmt.Sprintf("%s %s", plainMsg, color.YellowBold(testCase.expectedSubStr))
|
|
line2 := fmt.Sprintf("Update: %s", color.CyanBold(testCase.dlURL))
|
|
// Uncomment below to see message appearance:
|
|
// fmt.Println(output)
|
|
switch {
|
|
case testCase.dlURL == "" && output != "":
|
|
t.Errorf("Testcase %d: no newer release available but got an update message: %s", i+1, output)
|
|
case output == "" && testCase.dlURL != "" && testCase.older > 0:
|
|
t.Errorf("Testcase %d: newer release is available but got empty update message!", i+1)
|
|
case output == "" && (testCase.dlURL == "" || testCase.older <= 0):
|
|
// Valid no update message case. No further
|
|
// validation needed.
|
|
continue
|
|
case !strings.Contains(output, line1):
|
|
t.Errorf("Testcase %d: output '%s' did not contain line 1: '%s'", i+1, output, line1)
|
|
case !strings.Contains(output, line2):
|
|
t.Errorf("Testcase %d: output '%s' did not contain line 2: '%s'", i+1, output, line2)
|
|
}
|
|
}
|
|
}
|