WEB Carriers Safe-matrix Refactored

Co-Authored-By: brekotis <93345790+brekotis@users.noreply.github.com>

src/web/session/lanes/tests.rs

@@ -1,13 +1,26 @@
 use std::net::SocketAddr;
 use std::sync::Arc;
 
+use arc_swap::ArcSwap;
 use bytes::BytesMut;
 
 use super::*;
-use crate::config::{WebRuntimeProfile, WebSecretMode, WebTimeoutsConfig};
+use crate::config::{
+    ProxyConfig, WebCarrier, WebLimitsConfig, WebRuntimeProfile, WebSecretMode,
+    WebTimeoutsConfig,
+};
+use crate::maestro::generation::test_runtime_generation;
 use crate::web::manager::WebProcessRuntime;
+use crate::web::session::{CarrierLane, insert_carrier_lane};
 
 fn session_with_limits(limits: WebLimitsConfig) -> Arc<WebSession> {
+    new_session(limits, std::sync::Weak::new())
+}
+
+fn new_session(
+    limits: WebLimitsConfig,
+    manager: std::sync::Weak<WebProcessRuntime>,
+) -> Arc<WebSession> {
     let profile = Arc::new(WebRuntimeProfile {
         host: "proxy.example.com".to_string(),
         public_addr: SocketAddr::from(([203, 0, 113, 10], 443)),
@@ -25,7 +38,7 @@ fn session_with_limits(limits: WebLimitsConfig) -> Arc<WebSession> {
         max_streams_per_session: 2,
     });
     WebSession::new(
-        std::sync::Weak::<WebProcessRuntime>::new(),
+        manager,
         [1; 32],
         "192.0.2.10".parse().unwrap(),
         1,
@@ -35,22 +48,134 @@ fn session_with_limits(limits: WebLimitsConfig) -> Arc<WebSession> {
         1,
         [3; 32],
         None,
+        crate::web::manager::CarrierClientClass::Legacy,
+        None,
+        false,
         limits,
         WebTimeoutsConfig::default(),
     )
 }
 
+fn session_with_manager() -> (Arc<WebSession>, Arc<WebProcessRuntime>) {
+    session_with_manager_limits(WebLimitsConfig::default())
+}
+
+fn session_with_manager_limits(
+    limits: WebLimitsConfig,
+) -> (Arc<WebSession>, Arc<WebProcessRuntime>) {
+    let generation = test_runtime_generation(1, ProxyConfig::default());
+    let manager = WebProcessRuntime::start(Arc::new(ArcSwap::from(generation)));
+    let session = new_session(limits, Arc::downgrade(&manager));
+    (session, manager)
+}
+
 fn session() -> Arc<WebSession> {
     session_with_limits(WebLimitsConfig::default())
 }
 
+#[tokio::test]
+async fn early_down_waits_without_creating_a_provisional_lane() {
+    let (session, manager) = session_with_manager();
+    let polling = Arc::clone(&session);
+    let poll = tokio::spawn(async move { polling.poll_down_lane(7, 0).await });
+    while session.state.lock().lane_open_waits == 0 {
+        tokio::task::yield_now().await;
+    }
+    assert!(!session.state.lock().carrier_lanes.contains_key(&7));
+    {
+        let mut state = session.state.lock();
+        assert!(insert_carrier_lane(&mut state, 7).is_some());
+        state.closed_streams.insert(7);
+        assert!(session.queue_control_locked(&mut state, FrameType::Close, 7, &[]));
+    }
+    session.lane_open_notify.notify_waiters();
+    let result = tokio::time::timeout(Duration::from_secs(1), poll)
+        .await
+        .unwrap()
+        .unwrap()
+        .unwrap();
+    assert!(!result.body.is_empty());
+    assert_eq!(session.state.lock().lane_open_waits, 0);
+    drop(result);
+    session.close();
+    manager.shutdown().await;
+}
+
+#[tokio::test(start_paused = true)]
+async fn early_down_timeout_is_empty_and_releases_its_session_slot() {
+    let (session, manager) = session_with_manager();
+    let polling = Arc::clone(&session);
+    let poll = tokio::spawn(async move { polling.poll_down_lane(7, 0).await });
+    while session.state.lock().lane_open_waits == 0 {
+        tokio::task::yield_now().await;
+    }
+    tokio::time::advance(Duration::from_secs(3)).await;
+    let result = poll.await.unwrap().unwrap();
+    assert!(result.body.is_empty());
+    assert_eq!(result.next_cursor, 0);
+    assert!(!result.lane_closed);
+    assert_eq!(session.state.lock().lane_open_waits, 0);
+    session.close();
+    manager.shutdown().await;
+}
+
+#[tokio::test]
+async fn early_down_admission_is_bounded_and_cancellation_safe() {
+    let limits = WebLimitsConfig {
+        max_lane_open_waits_per_session: 2,
+        ..WebLimitsConfig::default()
+    };
+    let (session, manager) = session_with_manager_limits(limits);
+    let mut waits = Vec::new();
+    for lane_id in [7, 8] {
+        let polling = Arc::clone(&session);
+        waits.push(tokio::spawn(async move {
+            polling.poll_down_lane(lane_id, 0).await
+        }));
+    }
+    while session.state.lock().lane_open_waits < 2 {
+        tokio::task::yield_now().await;
+    }
+    assert!(matches!(
+        session.poll_down_lane(9, 0).await,
+        Err(ManagerError::Limit)
+    ));
+    for wait in waits {
+        wait.abort();
+        let _ = wait.await;
+    }
+    assert_eq!(session.state.lock().lane_open_waits, 0);
+    session.close();
+    manager.shutdown().await;
+}
+
+#[tokio::test]
+async fn session_close_wakes_early_down_with_closed_state() {
+    let (session, manager) = session_with_manager();
+    let polling = Arc::clone(&session);
+    let poll = tokio::spawn(async move { polling.poll_down_lane(7, 0).await });
+    while session.state.lock().lane_open_waits == 0 {
+        tokio::task::yield_now().await;
+    }
+    session.close();
+    assert!(matches!(
+        tokio::time::timeout(Duration::from_secs(1), poll)
+            .await
+            .unwrap()
+            .unwrap(),
+        Err(ManagerError::Closed)
+    ));
+    assert_eq!(session.state.lock().lane_open_waits, 0);
+    manager.shutdown().await;
+}
+
 #[test]
 fn lane_uplink_sequences_are_independent_and_exactly_once() {
     let session = session();
     {
         let mut state = session.state.lock();
         for lane_id in [51, 52] {
-            state.carrier_lanes.insert(lane_id, CarrierLane::new());
+            state.carrier_lanes.insert(lane_id, CarrierLane::new(u64::from(lane_id)));
             state.closed_streams.insert(lane_id);
         }
     }
@@ -75,20 +200,12 @@ fn cross_lane_frame_is_fatal_to_https_lane_session() {
 
 #[tokio::test]
 async fn drained_closed_lane_replays_then_signals_completion() {
-    let session = session();
+    let (session, manager) = session_with_manager();
     {
         let mut state = session.state.lock();
-        state.carrier_lanes.insert(7, CarrierLane::new());
+        state.carrier_lanes.insert(7, CarrierLane::new(7));
         state.closed_streams.insert(7);
-        let lane = state.carrier_lanes.get_mut(&7).unwrap();
-        let encoded = frame::encode(FrameType::Close, 7, &[]);
-        lane.pending_frames.push_back(QueuedFrame {
-            encoded: BytesMut::from(encoded.as_ref()),
-            frame_type: FrameType::Close,
-            stream_id: 7,
-            control: true,
-            cost: frame::HEADER_BYTES + QUEUE_ITEM_COST,
-        });
+        assert!(session.queue_control_locked(&mut state, FrameType::Close, 7, &[]));
     }
     let first = session.poll_down_lane(7, 0).await.unwrap();
     let replay = session.poll_down_lane(7, 0).await.unwrap();
@@ -97,6 +214,10 @@ async fn drained_closed_lane_replays_then_signals_completion() {
     let finished = session.poll_down_lane(7, 1).await.unwrap();
     assert!(finished.body.is_empty());
     assert!(finished.lane_closed);
+    drop(first);
+    drop(replay);
+    session.close();
+    manager.shutdown().await;
 }
 
 #[test]
@@ -108,7 +229,7 @@ fn tombstone_eviction_releases_lane_budget_and_accepts_late_frames() {
     let session = session_with_limits(limits);
     {
         let mut state = session.state.lock();
-        state.carrier_lanes.insert(7, CarrierLane::new());
+        state.carrier_lanes.insert(7, CarrierLane::new(7));
         let encoded = frame::encode(FrameType::Close, 7, &[]);
         let cost = encoded.len() + QUEUE_ITEM_COST;
         state
@@ -128,7 +249,7 @@ fn tombstone_eviction_releases_lane_budget_and_accepts_late_frames() {
         state.pending_control_bytes = cost;
         state.pending_control_items = 1;
         session.remember_closed_locked(&mut state, 7);
-        state.carrier_lanes.insert(8, CarrierLane::new());
+        state.carrier_lanes.insert(8, CarrierLane::new(8));
         session.remember_closed_locked(&mut state, 8);
         assert!(!state.carrier_lanes.contains_key(&7));
         assert_eq!(state.pending_bytes, 0);