mirror of
https://github.com/pgsty/minio.git
synced 2026-08-09 07:43:29 +03:00
Feng Ruohang
77bdc4c0cd
Two coupled changes that must land together, because the same files carry both: the server now identifies itself as Silo, and every path that would have called home to a MinIO-operated service is closed. Product identity - build-constants.go: store name, UA name and startup banner become Silo. The Go identifiers (MinioStoreName, MinioBannerName, ...) keep their names on purpose - renaming exported symbols would churn the compatibility surface for a cosmetic gain, and the rebrand guard freezes that surface. - main.go, server-startup-msg.go, ftp-server.go and the user-visible log, help and error strings across cmd/ and internal/ switch to Silo. Original MinIO copyright, LICENSE, NOTICE and CREDITS are untouched; --version now prints the upstream copyright, the pgsty modification notice, and the trademark policy's approved "based on MinIO technology" attribution. - api-headers.go: the HTTP Server header becomes "Silo". This is the one externally observable identity change, so TestCommonHeadersUseSiloProductName pins it - probes that sniff for "MinIO" must move to capability detection. - Prometheus metric HELP strings keep their MinIO wording. They are part of the metrics contract the guard protects, not product copy. Configuration directory - config-dir.go: new installs use ~/.silo. If only ~/.minio exists it is still read, with a one-time notice and no files moved. If both exist ~/.silo wins and an ambiguity warning is emitted; an explicit --config-dir always wins. Covered by TestSelectDefaultConfigDir. The internal .minio.sys layout is never renamed - this rule applies to the user config directory only. Upstream service lockdown - globalInplaceUpdateDisabled is now true at initialization rather than being set from MINIO_UPDATE. common-main.go still parses MINIO_UPDATE so upgrading nodes do not fail on an unknown key, but warns that the value is ignored; there is no way to re-enable the updater. TestInplaceUpdateCannotBeEnabled guards that. Without this, an admin with mc could have overwritten /usr/bin/silo with an upstream MinIO binary. - verifyBinary and commitBinary refuse early; the ServerUpdate v1/v2 admin routes and the peer-rest update endpoints stay registered and keep returning the existing programmatic error, so clients see a stable failure rather than a 404. - MinioReleaseBaseURL and defaultMinisignPubkey are emptied: no dl.min.io download root, and upstream's minisign key is no longer a trust root for anything this fork ships. - cmd/callhome.go is deleted and internal/config/subnet/ is reduced to parsing its old keys and reporting that the integration is disabled. config-current.go warns instead of failing when callhome or SUBNET settings are present, so an upgraded node with those keys still starts. - internal/config/errors.go replaces the MinIO Slack and support entry points with Silo documentation and issue links. Error codes and programmatic fields are unchanged. Verified: the compatibility baseline is unchanged except for the deliberate removal of the /api/health/upload SUBNET route; go build, go vet and the full cmd/ and internal/ unit suites pass; a locally built binary starts, serves S3/Admin/metrics on the unchanged /minio/* routes, answers with Server: Silo, and falls back to a pre-existing ~/.minio with the expected notice. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
79 lines
1.9 KiB
Go
79 lines
1.9 KiB
Go
// Copyright 2026 PGSTY contributors.
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
|
|
package cmd
|
|
|
|
import (
|
|
"bytes"
|
|
crand "crypto/rand"
|
|
"crypto/rsa"
|
|
"io"
|
|
"testing"
|
|
|
|
"github.com/minio/madmin-go/v3/estream"
|
|
)
|
|
|
|
func TestInspectDataUsesOnlyRequesterKey(t *testing.T) {
|
|
privateKey, err := rsa.GenerateKey(crand.Reader, 2048)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
var encoded bytes.Buffer
|
|
writer := estream.NewWriter(&encoded)
|
|
clusterInfo := []byte("local cluster metadata")
|
|
if err = addInspectDataKey(writer, &privateKey.PublicKey, clusterInfo); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
inspect, err := writer.AddEncryptedStream("inspect.zip", nil)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
inspectData := []byte("local inspect archive")
|
|
if _, err = inspect.Write(inspectData); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if err = inspect.Close(); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if err = writer.Close(); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
reader, err := estream.NewReader(bytes.NewReader(encoded.Bytes()))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
reader.SetPrivateKey(privateKey)
|
|
want := []struct {
|
|
name string
|
|
data []byte
|
|
}{
|
|
{name: "cluster.info", data: clusterInfo},
|
|
{name: "inspect.zip", data: inspectData},
|
|
}
|
|
for _, expected := range want {
|
|
stream, err := reader.NextStream()
|
|
if err != nil {
|
|
t.Fatalf("read %s: %v", expected.name, err)
|
|
}
|
|
if stream.Name != expected.name {
|
|
t.Fatalf("stream name = %q, want %q", stream.Name, expected.name)
|
|
}
|
|
got, err := io.ReadAll(stream)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if !bytes.Equal(got, expected.data) {
|
|
t.Fatalf("%s = %q, want %q", expected.name, got, expected.data)
|
|
}
|
|
}
|
|
if _, err = reader.NextStream(); err != io.EOF {
|
|
t.Fatalf("final stream error = %v, want EOF", err)
|
|
}
|
|
}
|