mirror of
https://github.com/pgsty/minio.git
synced 2026-08-10 00:03:29 +03:00
Feng Ruohang
6613c2a3cb
The test and verification scripts invoked ./minio and pulled their tooling from upstream infrastructure with no integrity check. Every `curl | tar` of a client or an old server binary was an unverified execution path in a script that regularly runs as a privileged user, and several fetched a floating "latest". Two installers replace all of it: - install-mcli.sh resolves a pinned pgsty/mc release, downloads the archive and its checksum manifest, requires exactly one valid manifest entry for the asset, verifies it, and installs. MCLI_BIN with a mandatory MCLI_SHA256 lets an offline or air-gapped run supply its own binary, still checksum-checked. - install-verified-fixture.sh takes source, expected SHA-256 and target, and refuses anything that does not match. Sources may be a URL or a local file. Every script that previously downloaded mc now calls install-mcli.sh. The three places that genuinely need an upstream artifact - the old MinIO server binary for the LDAP IAM upgrade-import test, the 2021 mc for the three-site replication test, and the functional-tests.sh fixture - go through install-verified-fixture.sh with the digest recorded inline. Those dl.min.io URLs remain on purpose: they are historical upstream artifacts needed to prove upgrade compatibility, and they are now pinned and verified rather than trusted. The scripts otherwise switch to ./silo, silo.service, the silo container and compose service names, and SILO_CONFIG_DIR. run-multi-site-minio-idp.sh is renamed to run-multi-site-silo-idp.sh with the Makefile target following. buildscripts/minio-upgrade.sh keeps its name and its `minio server` argv - it exists to test the MinIO-to-Silo upgrade, so the old side must stay old - but it is now pinned to an image digest rather than a tag, and its `docker system prune` and `docker volume prune` calls are removed. Those ran unfiltered against the developer's whole Docker installation; the resiliency tests had the same problem and lose their prune and `docker ps -q` sweeps too. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
82 lines
2.2 KiB
Bash
Executable File
82 lines
2.2 KiB
Bash
Executable File
#!/bin/bash
|
|
|
|
if [ -n "$TEST_DEBUG" ]; then
|
|
set -x
|
|
fi
|
|
|
|
pkill silo
|
|
docker rm -f $(docker ps -aq)
|
|
rm -rf /tmp/openid{1..4}
|
|
|
|
export MC_HOST_mysilo="http://minioadmin:minioadmin@localhost:22000"
|
|
# The service account used below is already present in iam configuration getting imported
|
|
export MC_HOST_mysilo1="http://dillon-service-2:dillon-service-2@localhost:22000"
|
|
|
|
# Start Silo instance
|
|
export CI=true
|
|
|
|
if [ ! -f ./mc ]; then
|
|
"$(git rev-parse --show-toplevel)/buildscripts/install-mcli.sh" ./mc
|
|
fi
|
|
|
|
mc -v
|
|
|
|
# Start openid server
|
|
(
|
|
cd ./minio-iam-testing
|
|
make docker-images
|
|
make docker-run
|
|
cd -
|
|
)
|
|
|
|
(silo server --address :22000 --console-address :10000 http://localhost:22000/tmp/openid{1...4} 2>&1 >/tmp/server.log) &
|
|
./mc ready mysilo
|
|
./mc mb mysilo/test-bucket
|
|
./mc cp /etc/hosts mysilo/test-bucket
|
|
|
|
./mc idp openid add mysilo \
|
|
config_url="http://localhost:5556/dex/.well-known/openid-configuration" \
|
|
client_id="minio-client-app" \
|
|
client_secret="minio-client-app-secret" \
|
|
scopes="openid,groups,email,profile" \
|
|
redirect_uri="http://127.0.0.1:10000/oauth_callback" \
|
|
display_name="Login via dex1" \
|
|
role_policy="consoleAdmin"
|
|
|
|
./mc admin service restart mysilo --json
|
|
./mc ready mysilo
|
|
./mc admin cluster iam import mysilo docs/distributed/samples/myminio-iam-info-openid.zip
|
|
|
|
# Verify if buckets / objects accessible using service account
|
|
echo "Verifying buckets and objects access for the imported service account"
|
|
|
|
./mc ls mysilo1/ --json
|
|
BKT_COUNT=$(./mc ls mysilo1/ --json | jq '.key' | wc -l)
|
|
if [ "${BKT_COUNT}" -ne 1 ]; then
|
|
echo "BUG: Expected no of bucket: 1, Found: ${BKT_COUNT}"
|
|
exit 1
|
|
fi
|
|
|
|
BKT_NAME=$(./mc ls mysilo1/ --json | jq '.key' | sed 's/"//g' | sed 's\/\\g')
|
|
if [[ ${BKT_NAME} != "test-bucket" ]]; then
|
|
echo "BUG: Expected bucket: test-bucket, Found: ${BKT_NAME}"
|
|
exit 1
|
|
fi
|
|
|
|
./mc ls mysilo1/test-bucket
|
|
OBJ_COUNT=$(./mc ls mysilo1/test-bucket --json | jq '.key' | wc -l)
|
|
if [ "${OBJ_COUNT}" -ne 1 ]; then
|
|
echo "BUG: Expected no of objects: 1, Found: ${OBJ_COUNT}"
|
|
exit 1
|
|
fi
|
|
|
|
OBJ_NAME=$(./mc ls mysilo1/test-bucket --json | jq '.key' | sed 's/"//g')
|
|
if [[ ${OBJ_NAME} != "hosts" ]]; then
|
|
echo "BUG: Expected object: hosts, Found: ${BKT_NAME}"
|
|
exit 1
|
|
fi
|
|
|
|
# Finally kill running processes
|
|
pkill silo
|
|
docker rm -f $(docker ps -aq)
|