mirror of
https://github.com/pgsty/minio.git
synced 2026-08-09 15:53:28 +03:00
e071bb77e4
helm/minio becomes helm/silo: chart name silo, version 6.0.0 -> 7.0.0, the MinIO wordmark icon replaced with the project's own, image.repository and mcImage.repository pointing at pgsty/silo, and the container command changed to silo. User-visible titles, comments and documentation links are rebranded. The MINIO_* environment variables and every existing values key are kept - the first Silo chart is a rename, not a values-schema migration. The hard problem is that a chart rename normally rewrites Kubernetes resource identity, and a StatefulSet's selector and volumeClaimTemplate are immutable. An existing release upgraded carelessly would either fail or orphan its PVCs. Two things address that: - Templates no longer derive the container name from .Chart.Name. It comes from a helper, so nameOverride can pin it, which means an existing release can be upgraded with nameOverride=minio, fullnameOverride=<existing-fullname> and serviceAccount.name=minio-sa and render byte-stable identity while switching chart and image. - helm-migration-guard and verify-helm-migration.sh make that a gate rather than a documented hope. The script lints the chart, renders it in distributed and standalone modes plus the optional templates, then renders the legacy chart from a pinned commit and the new chart with those three overrides and compares resource identity. The guard additionally rejects any rendered container still pulling pgsty/minio or invoking /usr/bin/minio. It runs through a pinned alpine/helm image when helm is not installed locally, so the gate does not depend on the developer's machine. Currently green over 7 compared resources. Rollback is asymmetric and the README says so: the old chart with the new image survives via the entrypoint argv shim, but the new chart with an old MinIO image does not, because `silo server` is not a command that binary knows. Only `helm rollback` is supported, never an image-only downgrade. Not addressed here: the default image tag is pgsty/silo:RELEASE.2026-08-04T00-00-00Z, which does not exist yet. The chart must not be published until the first Silo image is pushed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
123 lines
3.9 KiB
Bash
Executable File
123 lines
3.9 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
|
|
set -euo pipefail
|
|
|
|
script_dir="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
|
|
repo_dir="$(cd "${script_dir}/.." && pwd)"
|
|
baseline_commit="${HELM_LEGACY_COMMIT:-d88f46cce}"
|
|
helm_image="${HELM_IMAGE:-alpine/helm:3.18.6@sha256:c6d8088ddb279625a2e1ca3b08b22c18c946d1f65c8b810f28f1597435a1134c}"
|
|
work_dir="$(mktemp -d "${TMPDIR:-/tmp}/silo-helm.XXXXXX")"
|
|
|
|
cleanup() {
|
|
rm -rf "${work_dir}"
|
|
}
|
|
trap cleanup EXIT
|
|
|
|
cd "${repo_dir}"
|
|
git cat-file -e "${baseline_commit}^{commit}"
|
|
git archive "${baseline_commit}" helm/minio | tar -x -C "${work_dir}"
|
|
|
|
if command -v helm >/dev/null 2>&1; then
|
|
new_chart="${repo_dir}/helm/silo"
|
|
old_chart="${work_dir}/helm/minio"
|
|
output_dir="${work_dir}"
|
|
helm_run() {
|
|
helm "$@"
|
|
}
|
|
else
|
|
command -v docker >/dev/null 2>&1 || {
|
|
echo "helm or docker is required" >&2
|
|
exit 1
|
|
}
|
|
new_chart=/repo/helm/silo
|
|
old_chart=/check/helm/minio
|
|
output_dir=/check
|
|
helm_run() {
|
|
docker run --rm \
|
|
-v "${repo_dir}:/repo:ro" \
|
|
-v "${work_dir}:/check" \
|
|
"${helm_image}" "$@"
|
|
}
|
|
fi
|
|
|
|
helm_run lint "${new_chart}"
|
|
helm_run template silo "${new_chart}" \
|
|
--namespace silo \
|
|
--set rootUser=silo-admin \
|
|
--set rootPassword=test-password-123456 >/dev/null
|
|
helm_run template silo "${new_chart}" \
|
|
--namespace silo \
|
|
--set mode=standalone \
|
|
--set replicas=1 \
|
|
--set persistence.enabled=false \
|
|
--set rootUser=silo-admin \
|
|
--set rootPassword=test-password-123456 >/dev/null
|
|
|
|
# Exercise optional templates that the default render leaves dormant.
|
|
helm_run template silo-all "${new_chart}" \
|
|
--namespace silo \
|
|
--set rootUser=silo-admin \
|
|
--set rootPassword=test-password-123456 \
|
|
--set tls.enabled=true \
|
|
--set tls.certSecret=silo-tls \
|
|
--set trustedCertsSecret=silo-trusted-ca \
|
|
--set ingress.enabled=true \
|
|
--set consoleIngress.enabled=true \
|
|
--set networkPolicy.enabled=true \
|
|
--set podDisruptionBudget.enabled=true \
|
|
--set metrics.serviceMonitor.enabled=true \
|
|
--set metrics.serviceMonitor.includeNode=true \
|
|
--set 'buckets[0].name=chart-test' \
|
|
--set 'buckets[0].policy=none' \
|
|
--set 'buckets[0].purge=false' >/dev/null
|
|
|
|
# Existing values commonly address the historical myminio target. Render the
|
|
# custom-command path explicitly so both the new and compatibility aliases are
|
|
# protected by the release gate rather than only by a source-text assertion.
|
|
custom_render="${work_dir}/custom-command.yaml"
|
|
helm_run template silo-custom "${new_chart}" \
|
|
--namespace silo \
|
|
--set rootUser=silo-admin \
|
|
--set rootPassword=test-password-123456 \
|
|
--set-string 'customCommands[0].command=admin info myminio' \
|
|
--show-only templates/configmap.yaml >"${custom_render}"
|
|
for expected in \
|
|
'alias set mysilo' \
|
|
'alias set myminio' \
|
|
'runCommand admin info myminio'; do
|
|
grep -F -- "${expected}" "${custom_render}" >/dev/null || {
|
|
echo "rendered custom command is missing: ${expected}" >&2
|
|
exit 1
|
|
}
|
|
done
|
|
|
|
old_render="${work_dir}/legacy.yaml"
|
|
new_render="${work_dir}/candidate.yaml"
|
|
helm_run template my-release "${old_chart}" \
|
|
--namespace my-namespace \
|
|
--set rootUser=legacy-admin \
|
|
--set rootPassword=legacy-password-123456 >"${old_render}"
|
|
helm_run template my-release "${new_chart}" \
|
|
--namespace my-namespace \
|
|
-f "${old_chart}/values.yaml" \
|
|
--set rootUser=legacy-admin \
|
|
--set rootPassword=legacy-password-123456 \
|
|
--set nameOverride=minio \
|
|
--set fullnameOverride=my-release-minio \
|
|
--set serviceAccount.name=minio-sa \
|
|
--set image.repository=pgsty/silo \
|
|
--set mcImage.repository=pgsty/silo \
|
|
--set-string image.tag=RELEASE.2026-08-04T00-00-00Z \
|
|
--set-string mcImage.tag=RELEASE.2026-08-04T00-00-00Z >"${new_render}"
|
|
|
|
go run ./buildscripts/helm-migration-guard "${old_render}" "${new_render}"
|
|
|
|
helm_run package "${new_chart}" --destination "${output_dir}" >/dev/null
|
|
test -s "${work_dir}/silo-7.0.0.tgz"
|
|
if find "${work_dir}" -maxdepth 1 -type f -name 'minio-*.tgz' | grep -q .; then
|
|
echo "Helm packaging emitted a legacy MinIO chart name" >&2
|
|
exit 1
|
|
fi
|
|
|
|
echo "Silo Helm lint, render, legacy-upgrade, and package checks passed"
|