mirror of
https://github.com/pgsty/minio.git
synced 2026-11-09 17:21:51 +03:00
Feng Ruohang
b32a389e9d
A decommission or rebalance walk prechecks each due version of a key with the versions of the key in all pools, to decide whether the version moves or is left to its ILM expiry. Each precheck read and merged the key's whole history from every pool, so a key with V due versions read it V times in the walk alone; with long histories this grew roughly quadratically. Read the history once per key into a cache that the walk keeps for the entry, and evaluate every version's precheck against it. The precheck only chooses between moving a version and leaving it to the expiry; the expiry reads the history again under the object lock before it deletes anything, so a stale cache can only move a version or defer it to a recheck. A read error is kept, so every due version of that key moves. The expiry's own per-version reads are unchanged. Test: decommission and rebalance of a key with 63 due noncurrent versions read its history once, with the same outcome; without the cache they read it 63 times. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Feng Ruohang <rh@vonng.com>
62 lines
2.1 KiB
Go
62 lines
2.1 KiB
Go
// Copyright (c) 2026 PGSTY
|
|
//
|
|
// This file is part of Silo Object Storage stack
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package cmd
|
|
|
|
import (
|
|
"fmt"
|
|
"sync"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/minio/minio/internal/bucket/versioning"
|
|
)
|
|
|
|
// The walk of a decommission or a rebalance prechecks every due version of a
|
|
// key with the versions of the key in all pools. It reads that history once
|
|
// per key, not once per version.
|
|
func TestPoolsMigrationExpiryPrecheckReadsHistoryOnce(t *testing.T) {
|
|
for _, kind := range []string{"decommission", "rebalance"} {
|
|
t.Run(kind, func(t *testing.T) {
|
|
m := newMigrationILM(t, versioning.Enabled, false,
|
|
migrationILMRule("<NoncurrentVersionExpiration><NoncurrentDays>1</NoncurrentDays></NoncurrentVersionExpiration>"))
|
|
const key, versions = "obj-many", 64
|
|
for i := range versions {
|
|
m.put(key, fmt.Sprintf("v%02d", i), ObjectOptions{Versioned: true, MTime: UTCNow().AddDate(0, 0, -10).Add(-time.Duration(versions-i) * time.Minute)})
|
|
}
|
|
var mu sync.Mutex
|
|
loads := map[string]int{}
|
|
migrationHistoryLoaded = func(object string) {
|
|
mu.Lock()
|
|
loads[object]++
|
|
mu.Unlock()
|
|
}
|
|
t.Cleanup(func() { migrationHistoryLoaded = nil })
|
|
|
|
m.migrate(kind)
|
|
|
|
mu.Lock()
|
|
n := loads[key]
|
|
mu.Unlock()
|
|
if n != 1 {
|
|
t.Errorf("the walk read the history of %s %d times for %d due versions, want once", key, n, versions-1)
|
|
}
|
|
m.check(map[string][]string{key: {fmt.Sprintf("v%02d", versions-1)}})
|
|
})
|
|
}
|
|
}
|