mirror of
https://github.com/pgsty/minio.git
synced 2026-08-10 00:03:29 +03:00
Feng Ruohang
0c14d81510
The discrete PostgreSQL connection path concatenated raw values into a libpq keyword/value string. Whitespace, quotes, or backslashes could split a value into additional parameters or make an otherwise valid configuration fail to parse; the path also used the unsupported keyword username instead of user. Render every generated value as a single-quoted libpq parameter, escape quotes and backslashes, and use the correct user key. Keep the existing connection_string form untouched. The earlier attempt to register migrated PostgreSQL and MySQL fields is deliberately absent because those key names collide with the legacy connection-string tokenizer. Focused tests cover ordinary values, whitespace, quotes, backslashes, and parameter-shaped input. Co-authored-by: ChatGPT <noreply@openai.com> Co-authored-by: Claude <noreply@anthropic.com>
75 lines
2.3 KiB
Go
75 lines
2.3 KiB
Go
// Copyright (c) 2015-2023 MinIO, Inc.
|
|
//
|
|
// This file is part of MinIO Object Storage stack
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package target
|
|
|
|
import (
|
|
"database/sql"
|
|
"slices"
|
|
"testing"
|
|
)
|
|
|
|
// TestPostgreSQLRegistration checks if postgres driver
|
|
// is registered and fails otherwise.
|
|
func TestPostgreSQLRegistration(t *testing.T) {
|
|
var found bool
|
|
if slices.Contains(sql.Drivers(), "postgres") {
|
|
found = true
|
|
}
|
|
if !found {
|
|
t.Fatal("postgres driver not registered")
|
|
}
|
|
}
|
|
|
|
func TestPsqlTableNameValidation(t *testing.T) {
|
|
validTables := []string{"táblë", "table", "TableName", "\"Table name\"", "\"✅✅\"", "table$one", "\"táblë\""}
|
|
invalidTables := []string{"table name", "table \"name\"", "✅✅", "$table$"}
|
|
|
|
for _, name := range validTables {
|
|
if err := validatePsqlTableName(name); err != nil {
|
|
t.Errorf("Should be valid: %s - %s", name, err)
|
|
}
|
|
}
|
|
for _, name := range invalidTables {
|
|
if err := validatePsqlTableName(name); err != errInvalidPsqlTablename {
|
|
t.Errorf("Should be invalid: %s - %s", name, err)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestQuoteConnParam(t *testing.T) {
|
|
testCases := []struct {
|
|
value string
|
|
expected string
|
|
}{
|
|
{"localhost", "'localhost'"},
|
|
{"5432", "'5432'"},
|
|
// The reason this function exists: parameters are whitespace
|
|
// separated, so an unquoted space starts a new keyword.
|
|
{"pass word", "'pass word'"},
|
|
{"it's", `'it\'s'`},
|
|
{`back\slash`, `'back\\slash'`},
|
|
{`'; host=evil.example.com; x='`, `'\'; host=evil.example.com; x=\''`},
|
|
{"", "''"},
|
|
}
|
|
for _, testCase := range testCases {
|
|
if got := quoteConnParam(testCase.value); got != testCase.expected {
|
|
t.Errorf("quoteConnParam(%q) = %s, expected %s", testCase.value, got, testCase.expected)
|
|
}
|
|
}
|
|
}
|