mirror of
https://github.com/pgsty/minio.git
synced 2026-08-10 00:03:29 +03:00
Feng Ruohang
6613c2a3cb
The test and verification scripts invoked ./minio and pulled their tooling from upstream infrastructure with no integrity check. Every `curl | tar` of a client or an old server binary was an unverified execution path in a script that regularly runs as a privileged user, and several fetched a floating "latest". Two installers replace all of it: - install-mcli.sh resolves a pinned pgsty/mc release, downloads the archive and its checksum manifest, requires exactly one valid manifest entry for the asset, verifies it, and installs. MCLI_BIN with a mandatory MCLI_SHA256 lets an offline or air-gapped run supply its own binary, still checksum-checked. - install-verified-fixture.sh takes source, expected SHA-256 and target, and refuses anything that does not match. Sources may be a URL or a local file. Every script that previously downloaded mc now calls install-mcli.sh. The three places that genuinely need an upstream artifact - the old MinIO server binary for the LDAP IAM upgrade-import test, the 2021 mc for the three-site replication test, and the functional-tests.sh fixture - go through install-verified-fixture.sh with the digest recorded inline. Those dl.min.io URLs remain on purpose: they are historical upstream artifacts needed to prove upgrade compatibility, and they are now pinned and verified rather than trusted. The scripts otherwise switch to ./silo, silo.service, the silo container and compose service names, and SILO_CONFIG_DIR. run-multi-site-minio-idp.sh is renamed to run-multi-site-silo-idp.sh with the Makefile target following. buildscripts/minio-upgrade.sh keeps its name and its `minio server` argv - it exists to test the MinIO-to-Silo upgrade, so the old side must stay old - but it is now pinned to an image digest rather than a tag, and its `docker system prune` and `docker volume prune` calls are removed. Those ran unfiltered against the developer's whole Docker installation; the resiliency tests had the same problem and lose their prune and `docker ps -q` sweeps too. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
150 lines
3.8 KiB
Bash
Executable File
150 lines
3.8 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
|
|
echo "Running $0"
|
|
|
|
if [ -n "$TEST_DEBUG" ]; then
|
|
set -x
|
|
fi
|
|
|
|
trap 'catch $LINENO' ERR
|
|
|
|
# shellcheck disable=SC2120
|
|
catch() {
|
|
if [ $# -ne 0 ]; then
|
|
echo "error on line $1"
|
|
echo "dc1 server logs ========="
|
|
cat /tmp/dc1.log
|
|
echo "dc2 server logs ========="
|
|
cat /tmp/dc2.log
|
|
fi
|
|
|
|
echo "Cleaning up instances of Silo"
|
|
set +e
|
|
pkill silo
|
|
pkill mc
|
|
rm -rf /tmp/xl/
|
|
if [ $# -ne 0 ]; then
|
|
exit $#
|
|
fi
|
|
}
|
|
|
|
catch
|
|
|
|
set -e
|
|
export MINIO_CI_CD=1
|
|
export MINIO_BROWSER=off
|
|
export MINIO_ROOT_USER="minio"
|
|
export MINIO_ROOT_PASSWORD="silo123"
|
|
export MINIO_KMS_AUTO_ENCRYPTION=off
|
|
export MINIO_PROMETHEUS_AUTH_TYPE=public
|
|
export MINIO_KMS_SECRET_KEY=my-minio-key:OSMM+vkKUTCvQs9YL/CVMIMt43HFhkUpqJxTmGl6rYw=
|
|
unset MINIO_KMS_KES_CERT_FILE
|
|
unset MINIO_KMS_KES_KEY_FILE
|
|
unset MINIO_KMS_KES_ENDPOINT
|
|
unset MINIO_KMS_KES_KEY_NAME
|
|
|
|
if [ ! -f ./mc ]; then
|
|
"$(git rev-parse --show-toplevel)/buildscripts/install-mcli.sh" ./mc
|
|
fi
|
|
|
|
mkdir -p /tmp/xl/1/ /tmp/xl/2/
|
|
|
|
export MINIO_KMS_SECRET_KEY="my-minio-key:OSMM+vkKUTCvQs9YL/CVMIMt43HFhkUpqJxTmGl6rYw="
|
|
export MINIO_ROOT_USER="minioadmin"
|
|
export MINIO_ROOT_PASSWORD="minioadmin"
|
|
|
|
./silo server --address ":9001" /tmp/xl/1/{1...4}/ 2>&1 >/tmp/dc1.log &
|
|
pid1=$!
|
|
./silo server --address ":9002" /tmp/xl/2/{1...4}/ 2>&1 >/tmp/dc2.log &
|
|
pid2=$!
|
|
|
|
sleep 3
|
|
|
|
export MC_HOST_mysilo1=http://minioadmin:minioadmin@localhost:9001
|
|
export MC_HOST_mysilo2=http://minioadmin:minioadmin@localhost:9002
|
|
|
|
./mc ready mysilo1
|
|
./mc ready mysilo2
|
|
|
|
./mc mb mysilo1/testbucket/
|
|
./mc version enable mysilo1/testbucket/
|
|
./mc mb mysilo2/testbucket/
|
|
./mc version enable mysilo2/testbucket/
|
|
|
|
./mc replicate add mysilo1/testbucket --remote-bucket http://minioadmin:minioadmin@localhost:9002/testbucket/ --priority 1
|
|
|
|
# Test replication of delete markers and permanent deletes
|
|
|
|
./mc cp README.md mysilo1/testbucket/dir/file
|
|
./mc cp README.md mysilo1/testbucket/dir/file
|
|
|
|
sleep 1s
|
|
|
|
echo "=== mysilo1"
|
|
./mc ls --versions mysilo1/testbucket/dir/file
|
|
|
|
echo "=== mysilo2"
|
|
./mc ls --versions mysilo2/testbucket/dir/file
|
|
|
|
versionId="$(./mc ls --json --versions mysilo1/testbucket/dir/ | tail -n1 | jq -r .versionId)"
|
|
|
|
export AWS_ACCESS_KEY_ID=minioadmin
|
|
export AWS_SECRET_ACCESS_KEY=minioadmin
|
|
export AWS_REGION=us-east-1
|
|
|
|
aws s3api --endpoint-url http://localhost:9001 delete-object --bucket testbucket --key dir/file --version-id "$versionId"
|
|
|
|
./mc ls -r --versions mysilo1/testbucket >/tmp/mysilo1.txt
|
|
./mc ls -r --versions mysilo2/testbucket >/tmp/mysilo2.txt
|
|
|
|
out=$(diff -qpruN /tmp/mysilo1.txt /tmp/mysilo2.txt)
|
|
ret=$?
|
|
if [ $ret -ne 0 ]; then
|
|
echo "BUG: expected no missing entries after replication: $out"
|
|
exit 1
|
|
fi
|
|
|
|
./mc rm mysilo1/testbucket/dir/file
|
|
sleep 1s
|
|
|
|
./mc ls -r --versions mysilo1/testbucket >/tmp/mysilo1.txt
|
|
./mc ls -r --versions mysilo2/testbucket >/tmp/mysilo2.txt
|
|
|
|
out=$(diff -qpruN /tmp/mysilo1.txt /tmp/mysilo2.txt)
|
|
ret=$?
|
|
if [ $ret -ne 0 ]; then
|
|
echo "BUG: expected no missing entries after replication: $out"
|
|
exit 1
|
|
fi
|
|
|
|
# Test listing of non replicated permanent deletes
|
|
|
|
set -x
|
|
|
|
./mc mb mysilo1/foobucket/ mysilo2/foobucket/ --with-versioning
|
|
./mc replicate add mysilo1/foobucket --remote-bucket http://minioadmin:minioadmin@localhost:9002/foobucket/ --priority 1
|
|
./mc cp README.md mysilo1/foobucket/dir/file
|
|
|
|
versionId="$(./mc ls --json --versions mysilo1/foobucket/dir/ | jq -r .versionId)"
|
|
|
|
kill ${pid2} && wait ${pid2} || true
|
|
|
|
aws s3api --endpoint-url http://localhost:9001 delete-object --bucket foobucket --key dir/file --version-id "$versionId"
|
|
|
|
out="$(./mc ls mysilo1/foobucket/dir/)"
|
|
if [ "$out" != "" ]; then
|
|
echo "BUG: non versioned listing should not show pending/failed replicated delete:"
|
|
echo "$out"
|
|
exit 1
|
|
fi
|
|
|
|
out="$(./mc ls --versions mysilo1/foobucket/dir/)"
|
|
if [ "$out" != "" ]; then
|
|
echo "BUG: versioned listing should not show pending/failed replicated deletes:"
|
|
echo "$out"
|
|
exit 1
|
|
fi
|
|
|
|
echo "Success"
|
|
catch
|