Files
minio/cmd/bucket-lifecycle-incomplete.go
T
Feng Ruohang b10fd0e9c0 fix(ilm): report refused purges of all versions, and account their keys
An expiry of all versions of a key purges exactly that key, and the
purge can refuse it or stop early. Those outcomes were hard to see, and
the scanner reported a key it had queued as if it were already gone.

- Refusals and failures of a purge are counted in
  expiry_incomplete_total with their own reasons: tier_unsupported (a
  version is in a remote tier), budget (stopped after progress; the next
  expiry continues), changed (the latest version a batch matched
  changed) and history_unavailable. They are traced with the reason and
  send no removal event. A partial purge keeps its audit record, now
  with the reason. A tier refusal is also logged, once per key and hour,
  in words.
- A drive that cannot be read or decoded during the purge's own drive
  check now returns errDeleteAllHistoryUnavailable, which names the
  cause and stays a write quorum error (503) for API callers.
- The scanner does not queue an expiry of all versions whose latest
  version is hot when the pool holds a version in a remote tier: the
  purge would refuse it each cycle. It counts each such observation as
  tier_unsupported_skipped, once per drive scanner and cycle. A tiered
  version only another pool holds is unknown here, so the purge still
  decides; a transitioned latest version keeps the transitioned expiry.
  The tier predicate is shared with the purge's own check, for FileInfo
  and ObjectInfo, and excludes free versions.
- The scanner accounts every version of a key under an expiry of all
  versions at its size, queued or not, instead of as already removed.
  Usage, and so hard quota, drops after a fresh scan of the subtree once
  the purge succeeded. The alerts on many or large versions count the
  versions of a key that is not queued.
- A lifecycle expiry never deletes a prefix: DeleteObject refuses
  DeletePrefix with Expiration.Expire as InvalidArgument. No caller
  sends it since expiries of all versions became purges; a force delete
  of a prefix is unchanged.

Not done from the plan: queuing an MRF heal per version when a drive's
xl.meta fails to decode. Object heal does not rewrite metadata that
fails its CRC check (it reports the drive as unknown and skips it), so
those heals would not repair the drive. Such a key stays refused until
its metadata on that drive is repaired.

Tests: TestPurgeAllVersionsRefusalReasons,
TestPurgeAllVersionsRefusesCorruptDrive,
TestScannerSkipsDeleteAllForTieredKey and
TestPoolsDeleteObjectRejectsExpirePrefix are new. Tests that expected
the scanner to queue a refused purge, the predictive accounting, or
the old prefix options are converted.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Feng Ruohang <rh@vonng.com>
2026-11-06 19:59:42 +08:00

175 lines
6.3 KiB
Go

// Copyright (c) 2026 PGSTY
//
// This file is part of Silo Object Storage stack
//
// This program is free software: you can redistribute it and/or modify
// it under the terms of the GNU Affero General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// This program is distributed in the hope that it will be useful
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU Affero General Public License for more details.
//
// You should have received a copy of the GNU Affero General Public License
// along with this program. If not, see <http://www.gnu.org/licenses/>.
package cmd
import (
"context"
"errors"
"fmt"
"sync/atomic"
"github.com/minio/minio/internal/bucket/lifecycle"
"github.com/minio/minio/internal/event"
)
// An ILM expiry attempt that ends without removing what it addressed is
// incomplete: the rule no longer applied when it was checked again under the
// object lock, Object Lock protects the version, the history needed to decide
// could not be read, or another error. It is counted by reason, traced with
// the reason, and, unless it was refused, audited and logged. It never sends
// a removal notification: what it addressed is still there.
//
// An expiry of all versions of a key can also be refused because a version
// is in a remote tier, or because the latest version changed since a batch
// matched it, and it can stop at its budget after it removed some versions.
const (
ilmIncompleteNotApplicable = "not_applicable"
ilmIncompleteLocked = "locked"
ilmIncompleteHistoryUnavailable = "history_unavailable"
ilmIncompleteError = "error"
ilmIncompleteTierUnsupported = "tier_unsupported"
ilmIncompleteBudget = "budget"
ilmIncompleteChanged = "changed"
// ilmIncompleteTierSkipped counts the scanner's observations of a key
// whose expiry of all versions it did not queue, because a version it
// holds is in a remote tier and the purge would refuse it. Each drive's
// scanner of the key observes it, once per cycle.
ilmIncompleteTierSkipped = "tier_unsupported_skipped"
)
// ilmIncompleteReasons are the reasons expiry_incomplete_total counts, a
// bounded set of label values.
var ilmIncompleteReasons = []string{
ilmIncompleteNotApplicable,
ilmIncompleteLocked,
ilmIncompleteHistoryUnavailable,
ilmIncompleteError,
ilmIncompleteTierUnsupported,
ilmIncompleteBudget,
ilmIncompleteChanged,
ilmIncompleteTierSkipped,
}
// ilmIncompleteStats counts incomplete ILM expiries by reason.
type ilmIncompleteStats struct {
counts map[string]*atomic.Int64
}
func newILMIncompleteStats(reasons ...string) *ilmIncompleteStats {
s := &ilmIncompleteStats{counts: make(map[string]*atomic.Int64, len(reasons))}
for _, r := range reasons {
s.counts[r] = &atomic.Int64{}
}
return s
}
func (s *ilmIncompleteStats) add(reason string) {
if c, ok := s.counts[reason]; ok {
c.Add(1)
}
}
// snapshot returns the counts by reason.
func (s *ilmIncompleteStats) snapshot() map[string]int64 {
out := make(map[string]int64, len(s.counts))
for r, c := range s.counts {
out[r] = c.Load()
}
return out
}
var globalILMIncomplete = newILMIncompleteStats(ilmIncompleteReasons...)
// ilmExpiryNotDone classifies the error of an ILM expiry that did not remove
// what it addressed. A version that is already gone is not counted.
func ilmExpiryNotDone(err error) (reason string, counted bool) {
switch {
case err == nil || isErrObjectNotFound(err) || isErrVersionNotFound(err):
return "", false
case errors.Is(err, errDeleteAllTiered):
return ilmIncompleteTierUnsupported, true
case errors.Is(err, errDeleteAllChanged):
return ilmIncompleteChanged, true
case errors.Is(err, errDeleteAllBudget):
return ilmIncompleteBudget, true
case errors.Is(err, errLifecycleNotApplicable):
return ilmIncompleteNotApplicable, true
}
var locked ObjectLocked
if errors.As(err, &locked) {
return ilmIncompleteLocked, true
}
if isErrReadQuorum(err) || isErrWriteQuorum(err) {
return ilmIncompleteHistoryUnavailable, true
}
return ilmIncompleteError, true
}
// ilmExpiryRefused reports whether reason is a refusal, which changes
// nothing, rather than a failure.
func ilmExpiryRefused(reason string) bool {
switch reason {
case ilmIncompleteNotApplicable, ilmIncompleteLocked, ilmIncompleteTierUnsupported, ilmIncompleteChanged:
return true
}
return false
}
// reportILMExpiryNotDone reports an ILM expiry of oi that ended with err. It
// reports nothing and returns false when err says the version is already
// gone; the caller reports that as it did before.
func reportILMExpiryNotDone(ctx context.Context, oi ObjectInfo, lcEvent lifecycle.Event, src lcEventSrc, err error, logID string, traceFn func(event string, metadata map[string]string, err error)) bool {
reason, counted := ilmExpiryNotDone(err)
if !counted {
return false
}
globalILMIncomplete.add(reason)
if ilmExpiryRefused(reason) {
traceFn(ILMExpiry, map[string]string{"result": "refused", "reason": reason, "version-id": oi.VersionID}, nil)
return true
}
traceFn(ILMExpiry, map[string]string{"result": "failed", "reason": reason, "version-id": oi.VersionID}, err)
tags := newLifecycleAuditEvent(src, lcEvent).Tags()
tags["version-id"] = oi.VersionID
tags["ilm-incomplete-reason"] = reason
auditLogInternal(ctx, AuditLogOptions{
Event: ILMExpiry,
APIName: "ILMExpiry",
Bucket: oi.Bucket,
Object: oi.Name,
VersionID: oi.VersionID,
Error: err.Error(),
Tags: tags,
})
ilmLogOnceIf(ctx, fmt.Errorf("ILM expiry of %s/%s (%s) not done: %w", oi.Bucket, oi.Name, oi.VersionID, err), logID)
return true
}
// ilmExpiryEventName is the notification of an expiry that completed. An
// expiry that addressed no version ID (Expiration of a latest version in a
// versioned or suspended bucket) and whose result is a delete marker created
// that marker, also when the marker takes the null version ID of the version
// it replaces. Any other expiry removed the version it addressed, also when
// that version was itself a delete marker.
func ilmExpiryEventName(requestedVersionID string, result ObjectInfo) event.Name {
if requestedVersionID == "" && result.DeleteMarker {
return event.ObjectRemovedDeleteMarkerCreated
}
return event.ObjectRemovedDelete
}