mirror of
https://github.com/pgsty/minio.git
synced 2026-10-17 23:16:09 +03:00
Julien Laurenceau
a54d0c4354
NSScanner responses stream either a dataUsageEntry update or the final dataUsageCache. The grid framework recycles stream responses into a pool without resetting them, and the handler set only one field per response - so a recycled response still carried the Final (or Update) payload of an earlier scan. A remote node reading such a response accepted the stale final cache, corrupting bucket usage data across scanner cycles. Honor Recycler types when pooling stream responses, implement it for nsScannerResp, and clear the unset field at the response construction sites for defense in depth. Signed-off-by: Julien Laurenceau <julien.laurenceau@pepitedata.com>
37 lines
1.4 KiB
Go
37 lines
1.4 KiB
Go
// Copyright (c) 2015-2023 MinIO, Inc.
|
|
//
|
|
// This file is part of MinIO Object Storage stack
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package cmd
|
|
|
|
import "testing"
|
|
|
|
// TestNSScannerRespPooling verifies that recycled NSScanner stream
|
|
// responses cannot leak stale fields from a previous scan into new
|
|
// responses, which would otherwise produce incorrect bucket usage
|
|
// data.
|
|
func TestNSScannerRespPooling(t *testing.T) {
|
|
dirty := storageNSScannerRPC.NewResponse()
|
|
dirty.Update = &dataUsageEntry{}
|
|
dirty.Final = &dataUsageCache{}
|
|
storageNSScannerRPC.PutResponse(dirty)
|
|
|
|
resp := storageNSScannerRPC.NewResponse()
|
|
if resp.Update != nil || resp.Final != nil {
|
|
t.Fatalf("pooled nsScannerResp leaked stale fields: Update %v, Final %v", resp.Update, resp.Final)
|
|
}
|
|
}
|